This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
Ignore dot-prefixed files and subdirs when scanning packages #551
Merged
sdboyer
merged 5 commits into
golang:master
from
ascandella:ignore-directories-fillpackage
May 11, 2017
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
536add9
Don't try to parse directories named *.go
ascandella 2ff0643
Update logic to ignore all '.'-prefixed files
ascandella 474fb3e
Handle directories ending in .go
ascandella 78ecf7b
Add tests for recursing into dot-go directories
ascandella 27fbbf2
Fix header and test import
ascandella File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// Copyright 2017 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package foo | ||
|
||
import "sort" | ||
|
||
var _ = sort.Strings | ||
|
||
// yes, this is dumb, don't use ".go" in your directory names | ||
// See https://github.com/golang/dep/issues/550 for more information |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1280,6 +1280,28 @@ func TestListPackages(t *testing.T) { | |
}, | ||
}, | ||
}, | ||
"skip directories starting with '.'": { | ||
fileRoot: j("dotgodir"), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's also add e.g. a |
||
importRoot: "dotgodir", | ||
out: PackageTree{ | ||
ImportRoot: "dotgodir", | ||
Packages: map[string]PackageOrErr{ | ||
"dotgodir": { | ||
P: Package{ | ||
ImportPath: "dotgodir", | ||
Imports: []string{}, | ||
}, | ||
}, | ||
"dotgodir/foo.go": { | ||
P: Package{ | ||
ImportPath: "dotgodir/foo.go", | ||
Name: "foo", | ||
Imports: []string{"sort"}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
} | ||
|
||
for name, fix := range table { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this code, its not needed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it still is - in the event of e.g. a directory named
foo.go
(as the latest commit introduces). no?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still is. My comment about "NOTE: this doesn't handle directories" no longer applies, as demonstrated by the attached test case.