This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Version API Method Names #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
approved these changes
Jun 14, 2017
|
thanks! 🎉 |
|
I just stumbled upon this while rebasing a branch. This is a very nice improvement! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This PR proposes name changes for two gps version interface methods, primarily for the sake of readability (based on my experience working towards #431).
UnpairedVersioninterface methodIs:Old:
Is(Revision) PairedVersionNew:
Pair(Revision) PairedVersionPairedVersioninterface methodUnderlying:Old:
Underlying() RevisionNew:
Revision() RevisionJump to interface declarations
What should your reviewer look out for in this PR?
Reasons not to do this, or more idiomatic name alternatives.
Which issue(s) does this PR fix?
Related to #672 and #431