-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slog: update value receiver names #65
Conversation
This PR (HEAD: 424805c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/exp/+/516755. Important tips:
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/516755. |
Message from qiulaidongfeng: Patch Set 2: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/516755. |
Message from qiulaidongfeng: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/516755. |
Message from Jonathan Amsterdam: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/516755. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/516755. |
Message from Gopher Robot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/516755. |
Message from Jonathan Amsterdam: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/516755. |
Message from Ian Cottrell: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/516755. |
Message from qiulaidongfeng: Patch Set 3: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/516755. |
This change unifies the naming of the receivers in the value.go file (https://github.com/golang/exp/blob/master/slog/value.go). It also fixes the discrepancy between the doc comment ("v's value") and the receiver's name for this function: https://github.com/golang/exp/blob/d63ba01acd4b5892385c4390b334ea2c89f27eb7/slog/value.go#L281-L283 Change-Id: I66651b1c4746a868d54d24675119a2e28db8af42 GitHub-Last-Rev: 424805c GitHub-Pull-Request: #65 Reviewed-on: https://go-review.googlesource.com/c/exp/+/516755 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com> Run-TryBot: Jonathan Amsterdam <jba@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> Reviewed-by: qiulaidongfeng <2645477756@qq.com>
This PR is being closed because golang.org/cl/516755 has been merged. |
This change unifies the naming of the receivers in the value.go
file (https://github.com/golang/exp/blob/master/slog/value.go).
It also fixes the discrepancy between the doc comment
("v's value") and the receiver's name for this function:
exp/slog/value.go
Lines 281 to 283 in d63ba01