Export glog bugfix. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed before flag.Parse(). Before this change, premature logging resulted into log files being put in the default location (e.g. /tmp), but not the one specified by the log_dir flag. After this change, premature logging will not result into the creation of the log files yet. Instead, the log message will be printed to stderr.
|
Please sign the Google CLA so I can accept this pull request. |
|
Apologies, this is unnecessary because your employer is OK. Thanks for the PR. |
|
Should this comment on line 40 be updated? "// As a result, flag.Parse must be called before any logging is done." |
|
This breaks people who don't use the golang standard flag parsing library. Such as those who use https://github.com/spf13/pflag to get posix like flag parsing. Well, it doesn't break, but it prepends every log line with and incorrect |
|
Maybe pflag should call flag.CommandLine.Parse(nil) ? |
ldez
added a commit
to ldez/traefik
that referenced
this pull request
Jun 12, 2017
`golang/glog` is used by: - `github.com/mesos/mesos-go` (no version) - `k8s.io/client-go` (`44145f04b68cf362d9c4df2182967c2275eaefed`) In traefik#353 (add Mesos provider, 20 Jul 2016), the `golang/glog` hash is `fca8c8854093a154ff1eb580aae10276ad6b1b5f`. The problem appear in traefik#836 (use k8s client, 1 Dec 2016). Refs: - Traefik: - traefik#836 - traefik@131f581 - Glog - https://github.com/golang/glog/commits/master - golang/glog#13 - golang/glog@44145f0 - golang/glog@fca8c88 - k8s - https://github.com/kubernetes/client-go/blob/e121606b0d09b2e1c467183ee46217fa85a6b672/Godeps/Godeps.json - https://github.com/kubernetes/client-go/blob/master/Godeps/Godeps.json
ldez
added a commit
to traefik/traefik
that referenced
this pull request
Jun 12, 2017
`golang/glog` is used by: - `github.com/mesos/mesos-go` (no version) - `k8s.io/client-go` (`44145f04b68cf362d9c4df2182967c2275eaefed`) In #353 (add Mesos provider, 20 Jul 2016), the `golang/glog` hash is `fca8c8854093a154ff1eb580aae10276ad6b1b5f`. The problem appear in #836 (use k8s client, 1 Dec 2016). Refs: - Traefik: - #836 - 131f581 - Glog - https://github.com/golang/glog/commits/master - golang/glog#13 - golang/glog@44145f0 - golang/glog@fca8c88 - k8s - https://github.com/kubernetes/client-go/blob/e121606b0d09b2e1c467183ee46217fa85a6b672/Godeps/Godeps.json - https://github.com/kubernetes/client-go/blob/master/Godeps/Godeps.json
sathieu
added a commit
to lemonldap-ng-controller/lemonldap-ng-controller
that referenced
this pull request
Jan 30, 2018
k8s-ci-robot
pushed a commit
to kubernetes/test-infra
that referenced
this pull request
Mar 5, 2020
glog doesn't work well with pflag library (or any other flag replacemnt FWIW), see golang/glog#13.
DirectXMan12
pushed a commit
to DirectXMan12/klog
that referenced
this pull request
Jun 14, 2021
implements the glog API, but redirects to klog implementation. Makes it easy to use `dep` overrides to quickly switch/try the klog implementation. Change-Id: Ibdf4b25ed3b17e761c3fdea449f80add76a9070f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@robpike This is an export of an internal bug fix. The original author is @Sajmani
Fix problem that -log_dir will not be respected when anything is logged before flag.Parse().
Before this change, premature logging resulted into log files being put in the default location (e.g. /tmp), but not the one specified by the log_dir flag.
After this change, premature logging will not result into the creation of the log files yet. Instead, the log message will be printed to stderr.