Skip to content

Commit

Permalink
runtime: skip TestGdbPanic on Windows
Browse files Browse the repository at this point in the history
TestGdbPanic expects crash() to raise a SIGABRT signal interceptable
by gdb, but Windows doesn't have signals.

Windows builders haven't caught this failing test because they still
don't have gdb installed (tracked in #22021).

Change-Id: I7c7f2523a54d61aea0a9821c4db7c79e58a7217c
Reviewed-on: https://go-review.googlesource.com/c/go/+/473116
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Quim Muntal <quimmuntal@gmail.com>
  • Loading branch information
qmuntal authored and gopherbot committed Mar 3, 2023
1 parent 14015be commit 5e74bc1
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/runtime/runtime-gdb_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,10 @@ func TestGdbPanic(t *testing.T) {
t.Parallel()
checkGdbVersion(t)

if runtime.GOOS == "windows" {
t.Skip("no signals on windows")
}

dir := t.TempDir()

// Build the source code.
Expand Down

0 comments on commit 5e74bc1

Please sign in to comment.