-
Notifications
You must be signed in to change notification settings - Fork 17.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cmd/go/internal/modload: fix (*mvsReqs).Max when the second argument …
…is the empty string As far as I can tell, this bug had gone unnoticed because everything that uses Max so far happened to only ever present the empty string as the first argument. For #37438 Change-Id: Ie8c42313157d2c2c17e4058c53b5bb026b95a1c1 Reviewed-on: https://go-review.googlesource.com/c/go/+/266860 Trust: Bryan C. Mills <bcmills@google.com> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org>
- Loading branch information
Bryan C. Mills
committed
Nov 5, 2020
1 parent
a19a4dc
commit 67bf1c9
Showing
2 changed files
with
34 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// Copyright 2020 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package modload_test | ||
|
||
import ( | ||
"testing" | ||
|
||
"cmd/go/internal/modload" | ||
) | ||
|
||
func TestReqsMax(t *testing.T) { | ||
type testCase struct { | ||
a, b, want string | ||
} | ||
reqs := modload.Reqs() | ||
for _, tc := range []testCase{ | ||
{a: "v0.1.0", b: "v0.2.0", want: "v0.2.0"}, | ||
{a: "v0.2.0", b: "v0.1.0", want: "v0.2.0"}, | ||
{a: "", b: "v0.1.0", want: ""}, // "" is Target.Version | ||
{a: "v0.1.0", b: "", want: ""}, | ||
{a: "none", b: "v0.1.0", want: "v0.1.0"}, | ||
{a: "v0.1.0", b: "none", want: "v0.1.0"}, | ||
{a: "none", b: "", want: ""}, | ||
{a: "", b: "none", want: ""}, | ||
} { | ||
max := reqs.Max(tc.a, tc.b) | ||
if max != tc.want { | ||
t.Errorf("Reqs().Max(%q, %q) = %q; want %q", tc.a, tc.b, max, tc.want) | ||
} | ||
} | ||
} |