Skip to content

Commit

Permalink
runtime: mark riscv64 goexit with TOPFRAME
Browse files Browse the repository at this point in the history
This corrects backtraces in gdb, making the runtime gdb tests pass on
linux/riscv64.

Change-Id: Icdb71450f2ab58debb1fe18455793133108971d4
Reviewed-on: https://go-review.googlesource.com/c/go/+/231998
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
  • Loading branch information
4a6f656c committed May 4, 2020
1 parent 03e6073 commit a1ffbe9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/runtime/asm_riscv64.s
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ CALLFN(·call1073741824, 1073741824)
// func goexit(neverCallThisFunction)
// The top-most function running on a goroutine
// returns to goexit+PCQuantum.
TEXT runtime·goexit(SB),NOSPLIT|NOFRAME,$0-0
TEXT runtime·goexit(SB),NOSPLIT|NOFRAME|TOPFRAME,$0-0
MOV ZERO, ZERO // NOP
JMP runtime·goexit1(SB) // does not return
// traceback from goexit1 must hit code range of goexit
Expand Down

0 comments on commit a1ffbe9

Please sign in to comment.