Skip to content

Commit

Permalink
runtime: update skips for TestGdbBacktrace
Browse files Browse the repository at this point in the history
One issue simply has a reworded message, probably from a new version of
GDB. Another is a new issue.

Fixes #60553.
Fixes #58698.
Updates #39204.

Change-Id: I8389aa981fab5421f57ee761bfb5e1dd237709ed
Reviewed-on: https://go-review.googlesource.com/c/go/+/499975
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
  • Loading branch information
prattmic authored and gopherbot committed Jun 1, 2023
1 parent fdb3dc4 commit d045976
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions src/runtime/runtime-gdb_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -470,15 +470,17 @@ func TestGdbBacktrace(t *testing.T) {
got, err := cmd.CombinedOutput()
t.Logf("gdb output:\n%s", got)
if err != nil {
if bytes.Contains(got, []byte("internal-error: wait returned unexpected status 0x0")) {
switch {
case bytes.Contains(got, []byte("internal-error: wait returned unexpected status 0x0")):
// GDB bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28551
testenv.SkipFlaky(t, 43068)
}
if bytes.Contains(got, []byte("Couldn't get registers: No such process.")) {
case bytes.Contains(got, []byte("Couldn't get registers: No such process.")), bytes.Contains(got, []byte("Unable to fetch general registers.: No such process.")):
// GDB bug: https://sourceware.org/bugzilla/show_bug.cgi?id=9086
testenv.SkipFlaky(t, 50838)
}
if bytes.Contains(got, []byte(" exited normally]\n")) {
case bytes.Contains(got, []byte("waiting for new child: No child processes.")):
// GDB bug: Sometimes it fails to wait for a clone child.
testenv.SkipFlaky(t, 60553)
case bytes.Contains(got, []byte(" exited normally]\n")):
// GDB bug: Sometimes the inferior exits fine,
// but then GDB hangs.
testenv.SkipFlaky(t, 37405)
Expand Down

0 comments on commit d045976

Please sign in to comment.