Check RemoteAddr isn't nil before deref

golang · Jun 15, 2023 · ff3505d · ff3505d
1 parent c546321
commit ff3505d
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/net/http/server.go b/src/net/http/server.go
@@ -1856,7 +1856,9 @@ func isCommonNetReadError(err error) bool {
 
 // Serve a new connection.
 func (c *conn) serve(ctx context.Context) {
-	c.remoteAddr = c.rwc.RemoteAddr().String()
+	if ra := c.rwc.RemoteAddr(); ra != nil {
+		c.remoteAddr = ra.String()
+	}
 	ctx = context.WithValue(ctx, LocalAddrContextKey, c.rwc.LocalAddr())
 	var inFlightResponse *response
 	defer func() {