Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gccgo: rejects valid fp literal #11533

Closed
dvyukov opened this issue Jul 2, 2015 · 3 comments
Closed

gccgo: rejects valid fp literal #11533

dvyukov opened this issue Jul 2, 2015 · 3 comments
Labels
FrozenDueToAge
Milestone
Gccgo

Comments

@dvyukov
Copy link
Member

dvyukov commented Jul 2, 2015

gccgo fails to compile the following program:

package a
var f=09e1
go.go:2:8: error: expected ‘;’ or newline after top level declaration

gcc version 6.0.0 2015070 (experimental) (GCC)
@dvyukov
Copy link
Member Author

dvyukov commented Jul 2, 2015

@paranoiacblack

@ianlancetaylor ianlancetaylor added this to the Gccgo milestone Jul 10, 2015
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/13791 mentions this issue.

paranoiacblack pushed a commit to golang/gofrontend that referenced this issue Aug 25, 2015
@ianlancetaylor
compiler: Accept numeric literals with leading zeroes.
f97d579 
When a numeric literal with leading zeroes was seen in the parser, it
would only be accepted if it were a valid hex or octal literal.  Any
invalid numeric literal would be split up into multiple tokens: the
valid hex/octal literal followed by the rest of the characters.
Instead, when scanning a numeric literal with leading zeroes, always
accept the number and give an appropriate error if the accepted number
does not fit in the expected base.

Fixes golang/go#11532, golang/go#11533.

Change-Id: I2cac2348a0ab67fe9b97b77476cd7706b63a9db3
Reviewed-on: https://go-review.googlesource.com/13791
Reviewed-by: Ian Lance Taylor <iant@golang.org>
timshen91 pushed a commit to timshen91/gcc that referenced this issue Aug 26, 2015
compiler: Accept numeric literals with leading zeroes.
b35f0c3 
    
    When a numeric literal with leading zeroes was seen in the parser, it
    would only be accepted if it were a valid hex or octal literal.  Any
    invalid numeric literal would be split up into multiple tokens: the
    valid hex/octal literal followed by the rest of the characters.
    Instead, when scanning a numeric literal with leading zeroes, always
    accept the number and give an appropriate error if the accepted number
    does not fit in the expected base.
    
    Fixes golang/go#11532, golang/go#11533.
    
    Reviewed-on: https://go-review.googlesource.com/13791


git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@227193 138bc75d-0d04-0410-961f-82ee72b054a4
@dvyukov
Copy link
Member Author

dvyukov commented Aug 26, 2015

Fixed by golang/gofrontend@f97d579

@dvyukov dvyukov closed this as completed Aug 26, 2015
@golang golang locked and limited conversation to collaborators Sep 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Gccgo
Development

No branches or pull requests
4 participants
@paranoiacblack @dvyukov @ianlancetaylor @gopherbot