Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/poll: broken on js/wasm #26014

Closed
bradfitz opened this issue Jun 22, 2018 · 2 comments
Closed

internal/poll: broken on js/wasm #26014

bradfitz opened this issue Jun 22, 2018 · 2 comments
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.11

Comments

@bradfitz
Copy link
Contributor

The internal/poll package no longer compiles on js/wasm,

https://build.golang.org/log/908cfbdb52bc969cba46b83d84d47d4fa3ee0225

due to:

https://go-review.googlesource.com/c/go/+/119955#message-cbc791446ddd44f6a868d438c02e198e8e93d7ff

/cc @ianlancetaylor @neelance
@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. release-blocker arch-wasm WebAssembly issues labels Jun 22, 2018
@bradfitz bradfitz added this to the Go1.11 milestone Jun 22, 2018
@bradfitz bradfitz mentioned this issue Jun 22, 2018
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/120575 mentions this issue: cmd/dist: skip non-std tests on js/wasm

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/120576 mentions this issue: syscall, internal/poll: fix build on js/wasm

gopherbot pushed a commit that referenced this issue Jun 22, 2018
@bradfitz
cmd/dist: skip non-std tests on js/wasm
7d50abf 
After the std tests, most of the rest of the tests aren't applicable
to js/wasm. (anything with -cpu=>1, cgo, etc)

Skip them all for now. We can incrementally re-enable them over time
as the js/wasm port is fleshed out. But let's get the builder column
black again so we can enable trybots and keep it black.

Updates #26014
Updates #26015
Updates #18892

Change-Id: I8992ed3888f598fa42273ce8646a32d62ce45b1d
Reviewed-on: https://go-review.googlesource.com/120575
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@bradfitz bradfitz mentioned this issue Jun 25, 2018
Closed
@golang golang locked and limited conversation to collaborators Jun 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot