Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: remove support for Go 1.8 and earlier #26302

Closed
bradfitz opened this issue Jul 9, 2018 · 5 comments
Closed

x/net/http2: remove support for Go 1.8 and earlier #26302

bradfitz opened this issue Jul 9, 2018 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Jul 9, 2018

Our normal policy for x/* repos is to only support tip and the previous two Go releases.

Once Go 1.11 is out, that means we support tip, Go 1.11, and Go 1.10.

Let's clean up some of all the +build conditional code in x/net/http2 and merge a bunch of the files back together.

Because App Engine is only on Go 1.9, we can be lenient there and support back to Go 1.9.

Verify with grpc & App Engine, though, to make sure we don't break them.
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 9, 2018
@bradfitz bradfitz added this to the Go1.12 milestone Jul 9, 2018
@bradfitz bradfitz self-assigned this Jul 9, 2018
@bradfitz
Copy link
Contributor Author

@dfawley, what is your schedule or rationale for when and how you move grpc-go's minimum Go version? Looks like you still support Go 1.6 (as we kinda do, except for our tests started to accidentally require Go 1.7+?). But you're moving to Go 1.7? Would you be fine with Go 1.9, now that App Engine defaults to Go 1.9?

@dfawley
Copy link

dfawley commented Jul 10, 2018

I would defer to the AppEngine team (cc @broady) on this one. We were ready to drop support for 1.6 many, many months ago, but kept it in at their request. My preference would be to only support the same versions that are supported by Go (so, 1.9 & 1.10 now), and require users to vendor/use vgo in order to keep using older Go versions.

@broady
Copy link
Contributor

broady commented Jul 10, 2018

/cc @light @tbpg @jba @jadekler

Currently supported versions on GAE:

go1, go1.9, go1.8, and go1.6

1.9 is now the default.

@bradfitz bradfitz mentioned this issue Jul 25, 2018
Closed
@bradfitz
Copy link
Contributor Author

bradfitz commented Oct 11, 2018 •
edited
Loading

21 more days...
https://groups.google.com/forum/#!topic/google-appengine-go/wHsYtxvEbXI

We’re writing to let you know that we are deprecating Go 1.8 support on App Engine, and new deployments using this language version will no longer be available on November 1, 2018.

Edit: somebody sent me this countdown: https://www.timeanddate.com/countdown/generic?iso=20181101T00&p0=3399&msg=Go+1.6+%26+1.8+Deprecation&font=sanserif&csz=1

@dsnet dsnet mentioned this issue Oct 16, 2018
Merged
@sbuss sbuss mentioned this issue Oct 18, 2018
Merged
@dsnet dsnet mentioned this issue Oct 21, 2018
Merged
@puellanivis puellanivis mentioned this issue Oct 22, 2018
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/145677 mentions this issue: http2: remove support for Go 1.8 and earlier

@golang golang locked and limited conversation to collaborators Nov 1, 2019
dteh pushed a commit to dteh/fhttp that referenced this issue Jun 22, 2022
@bradfitz
http2: remove support for Go 1.8 and earlier
35a17b6 
Go's policy is to only support the past two releases (which is
currently Go 1.11 and Go 1.10). But because App Engine was stuck on Go
1.6 and Go 1.8 for so long, we kept kinda supporting Go 1.6 anyway,
even though we didn't actively test it with any CI system.

But that led to code getting disgusting and full of too many
+build-tagged files and indirection, as this change shows.

So, remove Go 1.8, Go 1.7, and Go 1.6 support. We still "support" Go
1.9 for now, even though it's also not actively tested.

Fixes golang/go#26302

Change-Id: I4aa5793173e50ffcd67be52a464492ca48fc9a23
Reviewed-on: https://go-review.googlesource.com/c/145677
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@bradfitz @broady @gopherbot @dfawley