Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vulndb: build broken on aix-ppc64 since 2021-10-18 due to "undefined: unix.Flock" in github.com/go-git/go-billy #49218

Closed
bcmills opened this issue Oct 29, 2021 · 7 comments
Closed

x/vulndb: build broken on aix-ppc64 since 2021-10-18 due to "undefined: unix.Flock" in github.com/go-git/go-billy #49218

bcmills opened this issue Oct 29, 2021 · 7 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-AIX release-blocker vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 29, 2021

greplogs --dashboard -md -l -e 'undefined: unix.Flock'

2021-10-28T22:38:00-4e1c44d-af05d8b/aix-ppc64
2021-10-28T21:17:17-4e1c44d-f6f024f/aix-ppc64
2021-10-28T20:50:34-4e1c44d-d0751b1/aix-ppc64
2021-10-28T19:04:41-4e1c44d-f229e70/aix-ppc64
2021-10-28T19:04:41-4e1c44d-9004433/aix-ppc64
2021-10-28T19:04:41-4e1c44d-18b9702/aix-ppc64
2021-10-28T19:04:32-a51a62e-9004433/aix-ppc64
2021-10-28T19:04:32-a51a62e-18b9702/aix-ppc64
2021-10-28T18:47:08-64f6208-f229e70/aix-ppc64
2021-10-28T18:47:08-64f6208-9004433/aix-ppc64
2021-10-28T18:47:08-64f6208-18b9702/aix-ppc64
2021-10-28T18:17:57-269162f-f229e70/aix-ppc64
2021-10-28T18:01:38-269162f-9004433/aix-ppc64
2021-10-28T14:25:03-269162f-a3bb28e/aix-ppc64
2021-10-28T03:44:12-269162f-2ff1074/aix-ppc64
2021-10-28T02:35:22-269162f-056dfe6/aix-ppc64
2021-10-28T01:15:26-269162f-b2fe2eb/aix-ppc64
2021-10-28T01:03:38-269162f-12dc48f/aix-ppc64
2021-10-28T00:11:24-269162f-a91d0b6/aix-ppc64
2021-10-27T22:17:35-269162f-79ff663/aix-ppc64
2021-10-27T21:37:54-269162f-749f6e9/aix-ppc64
2021-10-27T21:14:21-269162f-1a6281d/aix-ppc64
2021-10-27T21:13:34-269162f-3a03ddf/aix-ppc64
2021-10-27T18:24:50-8ed0999-259735f/aix-ppc64
2021-10-27T13:31:52-8ed0999-cfb5321/aix-ppc64
2021-10-27T13:31:52-8ed0999-c580180/aix-ppc64
2021-10-27T13:31:52-8ed0999-11b64b4/aix-ppc64
2021-10-27T13:12:49-db810f7-cfb5321/aix-ppc64
2021-10-27T08:50:27-db810f7-bdefb77/aix-ppc64
2021-10-27T06:23:35-db810f7-5786a54/aix-ppc64
2021-10-27T05:33:58-db810f7-ca5f65d/aix-ppc64
2021-10-26T23:12:17-db810f7-13eccaa/aix-ppc64
2021-10-26T22:05:53-db810f7-80be4a4/aix-ppc64
2021-10-26T21:32:57-db810f7-86f6bf1/aix-ppc64
2021-10-26T20:41:32-db810f7-3a0cd11/aix-ppc64
2021-10-26T20:12:32-db810f7-f8779b9/aix-ppc64
2021-10-26T20:09:49-db810f7-c580180/aix-ppc64
2021-10-26T20:09:49-db810f7-b54bdd2/aix-ppc64
2021-10-26T20:09:49-db810f7-11b64b4/aix-ppc64
2021-10-26T20:09:21-5720154-c580180/aix-ppc64
2021-10-26T20:09:21-5720154-11b64b4/aix-ppc64
2021-10-26T20:07:46-923fb23-c580180/aix-ppc64
2021-10-26T20:07:46-923fb23-1dc77a3/aix-ppc64
2021-10-26T20:07:46-923fb23-11b64b4/aix-ppc64
2021-10-26T20:07:42-3718231-c580180/aix-ppc64
2021-10-26T20:07:42-3718231-1dc77a3/aix-ppc64
2021-10-26T20:07:42-3718231-11b64b4/aix-ppc64
2021-10-26T20:05:50-a23f132-c580180/aix-ppc64
2021-10-26T20:05:50-a23f132-1dc77a3/aix-ppc64
2021-10-26T20:05:50-a23f132-11b64b4/aix-ppc64
2021-10-26T19:04:53-d192a0c-1dc77a3/aix-ppc64
2021-10-26T17:10:45-d192a0c-76cef81/aix-ppc64
2021-10-26T15:20:53-d192a0c-1b2362b/aix-ppc64
2021-10-26T14:24:17-d192a0c-283d8a3/aix-ppc64
2021-10-26T14:05:47-d192a0c-a2b8c18/aix-ppc64
2021-10-26T11:58:05-d192a0c-1e2820a/aix-ppc64
2021-10-26T05:05:24-d192a0c-23fdd7f/aix-ppc64
2021-10-26T01:22:47-d192a0c-adfb85b/aix-ppc64
2021-10-26T00:30:24-d192a0c-b36b001/aix-ppc64
2021-10-25T23:28:03-d192a0c-e9eb66d/aix-ppc64
2021-10-25T22:17:34-d192a0c-fd2f4b5/aix-ppc64
2021-10-25T21:51:20-d192a0c-85b3b4e/aix-ppc64
2021-10-25T21:16:46-d192a0c-11b64b4/aix-ppc64
2021-10-25T18:59:26-d192a0c-8c94aa4/aix-ppc64
2021-10-25T17:46:41-d192a0c-9012996/aix-ppc64
2021-10-25T17:29:14-d192a0c-95372ef/aix-ppc64
2021-10-25T17:02:16-d192a0c-52b10ab/aix-ppc64
2021-10-25T16:07:11-d192a0c-c6e82e5/aix-ppc64
2021-10-25T15:43:33-d192a0c-2c66cab/aix-ppc64
2021-10-25T15:31:40-d192a0c-89cc528/aix-ppc64
2021-10-25T14:50:31-d192a0c-1ed060c/aix-ppc64
2021-10-25T12:07:15-d192a0c-fcd2d9c/aix-ppc64
2021-10-25T03:00:02-d192a0c-7b55457/aix-ppc64
2021-10-23T20:23:35-d192a0c-8dbf3e9/aix-ppc64
2021-10-23T16:18:19-d192a0c-16318df/aix-ppc64
2021-10-23T16:17:58-d192a0c-3cd28ba/aix-ppc64
2021-10-23T12:44:47-d192a0c-b0f7eb6/aix-ppc64
2021-10-23T06:36:16-d192a0c-85d2751/aix-ppc64
2021-10-23T06:31:02-d192a0c-6c20001/aix-ppc64
2021-10-22T21:48:34-d192a0c-ae4d67c/aix-ppc64
2021-10-22T21:26:30-d192a0c-5d414d1/aix-ppc64
2021-10-22T21:12:07-d192a0c-76dd01f/aix-ppc64
2021-10-22T14:05:31-d192a0c-ff8115d/aix-ppc64
2021-10-20T16:16:50-d192a0c-c580180/aix-ppc64
2021-10-20T16:16:50-d192a0c-2ac3bdf/aix-ppc64
2021-10-20T15:03:54-215180e-27a1454/aix-ppc64
2021-10-20T10:27:25-215180e-d2ec73c/aix-ppc64
2021-10-20T10:27:25-215180e-c580180/aix-ppc64
2021-10-20T10:27:25-215180e-2ac3bdf/aix-ppc64
2021-10-20T10:27:05-e16c789-d2ec73c/aix-ppc64
2021-10-20T10:27:05-e16c789-c580180/aix-ppc64
2021-10-20T10:27:05-e16c789-2ac3bdf/aix-ppc64
2021-10-20T07:49:28-6bbd1d5-d2ec73c/aix-ppc64
2021-10-20T07:21:22-6bbd1d5-d9421ce/aix-ppc64
2021-10-20T05:28:45-6bbd1d5-b091189/aix-ppc64
2021-10-20T00:05:22-6bbd1d5-4cc6a91/aix-ppc64
2021-10-19T22:47:48-6bbd1d5-2be5b84/aix-ppc64
2021-10-19T21:05:11-6bbd1d5-1b24c9e/aix-ppc64
2021-10-19T20:36:35-6bbd1d5-c580180/aix-ppc64
2021-10-19T20:36:35-6bbd1d5-2ac3bdf/aix-ppc64
2021-10-19T20:36:35-6bbd1d5-07e5527/aix-ppc64
2021-10-19T18:56:08-0b3725f-07e5527/aix-ppc64
2021-10-19T18:11:09-0b3725f-c580180/aix-ppc64
2021-10-19T18:11:09-0b3725f-2ac3bdf/aix-ppc64
2021-10-19T17:32:25-2c78219-c580180/aix-ppc64
2021-10-19T17:32:25-2c78219-404f84d/aix-ppc64
2021-10-19T17:32:25-2c78219-2ac3bdf/aix-ppc64
2021-10-19T17:26:13-1056f9e-c580180/aix-ppc64
2021-10-19T17:26:13-1056f9e-404f84d/aix-ppc64
2021-10-19T17:26:13-1056f9e-2ac3bdf/aix-ppc64
2021-10-19T17:12:53-5b12521-404f84d/aix-ppc64
2021-10-19T16:14:12-5b12521-c580180/aix-ppc64
2021-10-19T16:14:12-5b12521-2ac3bdf/aix-ppc64
2021-10-19T16:14:12-5b12521-067d796/aix-ppc64
2021-10-19T15:03:39-052e8df-6294207/aix-ppc64
2021-10-19T11:52:34-052e8df-bde0463/aix-ppc64
2021-10-19T09:49:38-052e8df-b0351bf/aix-ppc64
2021-10-19T08:44:22-052e8df-1e49210/aix-ppc64
2021-10-19T07:45:46-052e8df-ee92daa/aix-ppc64
2021-10-19T07:37:24-052e8df-8838a3b/aix-ppc64
2021-10-18T22:56:07-052e8df-eba0e86/aix-ppc64
2021-10-18T21:57:36-052e8df-3befaf0/aix-ppc64
2021-10-18T21:21:54-052e8df-6c0daa7/aix-ppc64
2021-10-18T21:10:33-052e8df-c580180/aix-ppc64
2021-10-18T21:10:33-052e8df-2ac3bdf/aix-ppc64
2021-10-18T21:10:33-052e8df-267abbe/aix-ppc64
2021-10-18T20:55:30-9051627-c580180/aix-ppc64
2021-10-18T20:55:30-9051627-2ac3bdf/aix-ppc64
2021-10-18T20:55:30-9051627-267abbe/aix-ppc64
@gopherbot gopherbot added this to the Unreleased milestone Oct 29, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Oct 29, 2021

From the Git history for the go.sum line for the broken dependency, I believe that this started as of CL 356391 (CC @julieqiu @rolandshoemaker)

This is a release-blocker via #11811. Given that it is in x/vulndb, one option might be to skip that repository on the aix-ppc64 builder.

Another option might be to upstream AIX file-locking support in the third-party library. (See also #33974; note that the existing cmd/go/internal/lockedfile package has supported AIX reliably since CL 222277. 😁)

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-AIX release-blocker labels Oct 29, 2021
@bcmills bcmills modified the milestones: Unreleased, Go1.18 Oct 29, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Oct 29, 2021

(CC @go-git)

@rolandshoemaker
Copy link
Member

@bcmills how does one go about disabling a builder for an entire repo, is there some builder configuration file to touch, or is just adding a if GOOS == ... override in the tests?

@bcmills
Copy link
Contributor Author

bcmills commented Nov 1, 2021

You can skip a repo by editing the buildsRepo hook in golang.org/x/build/dashboard/builders.go:
https://github.com/golang/build/blob/79bb74b4be072b7741310726f68175684557ae60/dashboard/builders.go#L2503-L2513

(I have another change outstanding for this builder in CL 354755, so if you go that route we may end up needing to resolve some minor merge conflicts.)

@bcmills
Copy link
Contributor Author

bcmills commented Nov 1, 2021

It's not clear to me whether you could add a GOOS override in the tests. The log looks to me like it is failing at build time, which would imply a //go:build constraint rather than a run-time check — but it isn't clear to me that this dependency is something that you can meaningfully valve off with a constraint like that.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/360414 mentions this issue: dashboard: skip vulndb on aix-ppc64

@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Sep 8, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/508655 mentions this issue: dashboard: disable pkgsite on misc-compile-aix-ppc64 builder

gopherbot pushed a commit to golang/build that referenced this issue Jul 10, 2023
@matloob @gopherbot
dashboard: disable pkgsite on misc-compile-aix-ppc64 builder
67e9336 
It doesn't build for the same reason the vulndb repo doesn't build: a
dependency on github.com/go-git/go-billy.

For golang/go#49218
For golang/go#61209

Change-Id: I220a56ee330ec6de6d6467c6ca71e7f536121462
Reviewed-on: https://go-review.googlesource.com/c/build/+/508655
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Michael Matloob <matloob@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-AIX release-blocker vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Go Security
Status: No status
Milestone
Go1.18
Development

No branches or pull requests
4 participants
@rolandshoemaker @bcmills @julieqiu @gopherbot