Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: audit for Go 1.19 #53310

Closed
cherrymui opened this issue Jun 9, 2022 · 5 comments
Closed

api: audit for Go 1.19 #53310

cherrymui opened this issue Jun 9, 2022 · 5 comments
Assignees
@rsc
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.19

Comments

@cherrymui
Copy link
Member

cherrymui commented Jun 9, 2022 •
edited by dmitshur
Loading

This is a tracking issue for doing an audit of API additions for Go 1.19 as of https://go.dev/cl/411394.

New API changes for Go 1.19

crypto/x509

Covered:

Not originally covered, but covered later in #50674 (comment):

debug/elf

debug/pe

encoding/binary

encoding/csv

encoding/xml

flag

fmt

go/doc

go/doc/comment

go/types

hash/maphash

html/template

net/http

net/url

os/exec

regexp/syntax

runtime/debug

sort

sync/atomic

time
@cherrymui cherrymui added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. release-blocker okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels Jun 9, 2022
@dmitshur dmitshur added this to the Go1.19 milestone Jun 9, 2022
@gopherbot gopherbot removed the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Jun 10, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/414515 mentions this issue: api: correct debug/pe issue number for Go 1.19 changes

@rsc
Copy link
Contributor

rsc commented Jun 27, 2022

The issue number was wrong for the debug/pe changes, probably my fault creating the initial file set. Sent https://go.dev/cl/414515 to fix.

There are a few unexpected API additions attributed to #50674. I will look more closely at those.

Everything else is as proposed and accepted.

@rsc
Copy link
Contributor

rsc commented Jun 27, 2022

The new fields for #50674 look fine but they are undocumented
(https://go-review.googlesource.com/c/go/+/390834/6/src/crypto/x509/x509.go#2081).
I will ask Roland to add docs and then this issue can be closed.

gopherbot pushed a commit that referenced this issue Jun 28, 2022
@rsc
api: correct debug/pe issue number for Go 1.19 changes
d3ffff2 
It was #51868 not #51686.

For #53310.

Change-Id: I2cf28ca4de65e7030fdbd05e7f32fe42c8f3ca0a
Reviewed-on: https://go-review.googlesource.com/c/go/+/414515
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@rsc
Copy link
Contributor

rsc commented Jun 28, 2022

CL 414635 updates the comment. Once it is in we can close this issue.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jun 29, 2022
@dmitshur
Copy link
Contributor

CL 414635 is in. Thank you, closing as done.

(I've also checked off the last 3 boxes so it's clear we didn't accidentally miss them. They corresponded to the 3 more fields for #50674, which Russ said was fine, no objections in #50674 (comment), and they're now documented.)

jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
@rsc @jproberts
api: correct debug/pe issue number for Go 1.19 changes
beec7fa 
It was golang#51868 not golang#51686.

For golang#53310.

Change-Id: I2cf28ca4de65e7030fdbd05e7f32fe42c8f3ca0a
Reviewed-on: https://go-review.googlesource.com/c/go/+/414515
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@golang golang locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rsc rsc

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
Release Blockers
Status: Done
Milestone
Go1.19
Development

No branches or pull requests
4 participants
@rsc @dmitshur @gopherbot @cherrymui