Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: wrong link to go1.19 sync/atomic package #53453

Closed
jincheng9 opened this issue Jun 19, 2022 · 2 comments
Closed

x/website: wrong link to go1.19 sync/atomic package #53453

jincheng9 opened this issue Jun 19, 2022 · 2 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Milestone
Go1.19

Comments

@jincheng9
Copy link

jincheng9 commented Jun 19, 2022 •
edited
Loading

What version of Go are you using (go version)?

Go 1.19 Beta 1

What did you do?

https://tip.golang.org/doc/go1.19
image

What did you expect to see?

The link to new types in the sync/atomic package is wrong. Currently the link is https://tip.golang.org/doc/go1.19#sync/atomic, which cannot redirect to the sync/atomic package documents.

What did you see instead?

can redirect to https://pkg.go.dev/sync/atomic@master
@gopherbot gopherbot added this to the Unreleased milestone Jun 19, 2022
@jincheng9 jincheng9 changed the title x/website: wrong link x/website: wrong link to go1.19 sync/atomic package Jun 19, 2022
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 21, 2022
@dmitshur dmitshur modified the milestones: Unreleased, Go1.19 Jun 21, 2022
@dmitshur
Copy link
Contributor

Thanks for reporting. CL 413235 will fix this.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/413235 mentions this issue: doc/go1.19: use correct link to sync/atomic docs

jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
@ianlancetaylor @jproberts
doc/go1.19: use correct link to sync/atomic docs
a9918cf 
For golang#51400
Fixes golang#53453

Change-Id: Ie11182a16299cf26d03970d6aa9bfe03caa56ea4
Reviewed-on: https://go-review.googlesource.com/c/go/+/413235
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
4 participants
@jincheng9 @dmitshur @ianlancetaylor @gopherbot