Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go test deadlocked without enforcing timeouts when killed with ^C [1.20 backport] #60849

Closed
gopherbot opened this issue Jun 16, 2023 · 2 comments
Closed

cmd/go: go test deadlocked without enforcing timeouts when killed with ^C [1.20 backport] #60849

gopherbot opened this issue Jun 16, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Milestone
Go1.20.6

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #60203 to be considered for backport to the next 1.20 minor release.

@gopherbot, please backport to Go 1.20. This was a regression in Go 1.20, and causes annoying deadlocks (a UX issue) when attempting to cancel test runs.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 16, 2023
@gopherbot gopherbot mentioned this issue Jun 16, 2023
Closed
@bcmills bcmills added the GoCommand cmd/go label Jun 16, 2023
@gopherbot gopherbot added this to the Go1.20.6 milestone Jun 16, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/504062 mentions this issue: [release-branch.go1.20] cmd/go/internal/test: don't wait for previous test actions when interrupted

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Jun 21, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 21, 2023
gopherbot pushed a commit that referenced this issue Jun 22, 2023
@gopherbot
[release-branch.go1.20] cmd/go/internal/test: don't wait for previous…
b8e67d1 
… test actions when interrupted

Fixes #60849.
Updates #60203.

Change-Id: I59a3320ede1eb3cf4443d7ea37b8cb39d01f222a
Reviewed-on: https://go-review.googlesource.com/c/go/+/503936
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
(cherry picked from commit 6087671)
Reviewed-on: https://go-review.googlesource.com/c/go/+/504062
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging b8e67d1 to release-branch.go1.20.

@golang golang locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Projects
None yet
Milestone
Go1.20.6
Development

No branches or pull requests
2 participants
@bcmills @gopherbot