Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/fix: invalid -go=go1.21.0 [1.21 backport] #68824

Closed
gopherbot opened this issue Aug 9, 2024 · 3 comments
Closed

cmd/fix: invalid -go=go1.21.0 [1.21 backport] #68824

gopherbot opened this issue Aug 9, 2024 · 3 comments
Milestone
Go1.21.14

Comments

@gopherbot
Copy link
Contributor

@kolyshkin requested issue #62584 to be considered for backport to the next 1.21 minor release.

@gopherbot Please backport to Go 1.22.

When I run go fix using Go 1.22.5, it complains:

invalid -go=go1.21.0
exit status 2

While go1.23rc2 fix works fine.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 9, 2024
@gopherbot gopherbot mentioned this issue Aug 9, 2024
Closed
@gopherbot gopherbot added this to the Go1.21.14 milestone Aug 9, 2024
@kolyshkin
Copy link
Contributor

Checked with go 1.21.13 (with go.mod having go 1.21.0:

$ go1.21.13 fix ./...
invalid -go=go1.21.0
exit status 2
...

@kolyshkin
Copy link
Contributor

Can't open a backport myself for reasons described in #68825 (comment)

kolyshkin added a commit to kolyshkin/buildah that referenced this issue Aug 10, 2024
@kolyshkin
*: fix build tags
24da188 
This change is generated by `go1.23rc2 fix ./...`.

Had to use go1.23rc2, since all released go versions have a bug
preventing it from working with `go 1.22.0` in go.mod (opened
golang/go#68825,
golang/go#68824 for awareness).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@dmitshur
Copy link
Contributor

Closing this issue since Go 1.21 is now outside of its support window and won't have further minor releases.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
@dmitshur dmitshur removed the CherryPickCandidate Used during the release process for point releases label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Go1.21.14
Development

No branches or pull requests
3 participants
@dmitshur @kolyshkin @gopherbot