net/http: use fake Transport network when running in Node #25663
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: 2ed8445) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/115495 to see it. Tip: You can toggle comments from me using the |
|
Message from Agniva De Sarker: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/115495. |
Replaces the existing local loopback check with a check to see whether the program is being interpreted by Node. This means tests that are run with Node will use the fake network while still allowing users who are using js/wasm to talk to local networks.
|
This PR (HEAD: 43d26af) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/115495 to see it. Tip: You can toggle comments from me using the |
|
Message from Johan Brandhorst: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/115495. |
|
Message from Agniva De Sarker: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/115495. |
|
Message from Brad Fitzpatrick: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/115495. |
|
Message from Brad Fitzpatrick: Patch Set 2: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/115495. |
Replaces the existing local loopback check with a check to see whether the program is being interpreted by Node. This means tests that are run with Node will use the fake network while still allowing users who are using js/wasm to talk to local networks. Updates #25506 Change-Id: I8bc3c6808fa29293b7ac5f77b186140c4ed90b51 GitHub-Last-Rev: 43d26af GitHub-Pull-Request: #25663 Reviewed-on: https://go-review.googlesource.com/115495 Reviewed-by: Agniva De Sarker <agniva.quicksilver@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
|
This PR is being closed because golang.org/cl/115495 has been merged. |
Replaces the existing local loopback check with a check to see whether the program is being interpreted by Node. This means tests that are run with Node will use the fake network while still allowing users who are using js/wasm to talk to local networks. Updates #25506 Change-Id: I8bc3c6808fa29293b7ac5f77b186140c4ed90b51 GitHub-Last-Rev: 43d26af7bc716b7a01dd8f47d7a2c2a2df549489 GitHub-Pull-Request: golang/go#25663 Reviewed-on: https://go-review.googlesource.com/115495 Reviewed-by: Agniva De Sarker <agniva.quicksilver@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Replaces the existing local loopback check with a check to see
whether the program is being interpreted by Node. This means
tests that are run with Node will use the fake network while still
allowing users who are using js/wasm to talk to local networks.
Updates #25506