-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/url: add URL.Masked() #34686
net/url: add URL.Masked() #34686
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Add method to mask the password in an URL, it's a derived method from String() that's safe to be shown in logs.
c4d5a9d
to
433ea7c
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: 433ea7c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/198799 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/198799. |
Message from Matt Layher: Patch Set 1: Code-Review-1 Sorry, I don't think this is a necessary addition to the standard library. Why not add this helper where you need it? A proposal issue is the proper place to discuss this idea, rather than submitting a change. Please don’t reply on this GitHub thread. Visit golang.org/cl/198799. |
Message from nrxr: Patch Set 1:
Hi Matt, Indeed, I already have it as a helper for myself (see: https://github.com/nrxr/maskpass). My proposal for addition comes as I was listening today to the Go Time podcast about security (see: https://pca.st/nzc8wpta) and I saw more people could be using it as it's very common to output URLs to logs. It was my thinking at the moment of writing the patch set that maybe having a log-friendly mode in the standard library for something as regularly used as URLs would be really helpful instead of leaving it to helpers. I understand if it's deemed unnecessary, my intention was to propose a sensible default for something that may create security issues for a regular developer. Let me know if the consensus is that I should be submitting this as a proposal issue instead and I'll do just that. Please don’t reply on this GitHub thread. Visit golang.org/cl/198799. |
Add method to mask the password in an URL, it's a derived method from
String() that's safe to be shown in logs.