net: add IP.IsPrivate #42793

6543 · 2020-11-24T01:06:36Z

Adds a new method IsPrivate to check if an IP is
private according to RFC 1918 & RFC 4193.

google-cla · 2020-11-24T01:06:40Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

6543 · 2020-11-24T01:08:35Z

creddits to @MaxSem as I used your pull (#30278) as template :)

I would mention you in the comment but it does not look like souch information is wantend in the commit history so I leave it out...

gopherbot · 2020-11-24T01:15:45Z

This PR (HEAD: c73fccc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/272668 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-11-24T01:17:47Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-24T01:33:17Z

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-24T05:44:49Z

Message from 6543:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-24T14:08:59Z

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

bl-ue · 2020-12-19T14:16:28Z

Any progress on the fantastic feature??

6543 · 2021-01-03T23:29:33Z

@bl-ue feature-freeze (this pull will go into 1.17, if all works well)

bl-ue · 2021-01-03T23:37:35Z

Thank you @6543! I love this feature and can't wait for 1.17.

src/net/ip_test.go

gopherbot · 2021-01-05T01:34:54Z

This PR (HEAD: 70091ec) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/272668 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-02-03T15:25:32Z

This PR (HEAD: bb09bf6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/272668 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-02-16T13:07:03Z

This PR (HEAD: 29178a0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/272668 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-02-24T14:19:52Z

This PR (HEAD: b0729da) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/272668 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-02-26T02:24:05Z

Message from Ian Lance Taylor:

Patch Set 5: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-02-26T02:24:06Z

Message from Go Bot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e4601796

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-02-26T02:32:52Z

Message from Go Bot:

Patch Set 5:

Build is still in progress...
This change failed on linux-amd64-race:
See https://storage.googleapis.com/go-build-log/e4601796/linux-amd64-race_bce4afaa.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-02-26T02:40:29Z

Message from Go Bot:

Patch Set 5: TryBot-Result-1

1 of 21 TryBots failed:
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/e4601796/linux-amd64-race_bce4afaa.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-02-26T16:34:50Z

Message from Ian Lance Taylor:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-01T03:08:55Z

This PR (HEAD: 1c40030) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/272668 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-11T20:23:48Z

Message from 6543:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-12T03:03:48Z

Message from Emmanuel Odeke:

Patch Set 7: Run-TryBot+1

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-12T03:03:49Z

Message from Go Bot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e42efd82

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-12T03:06:02Z

Message from Go Bot:

Patch Set 7: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-12T12:18:39Z

This PR (HEAD: ad0bdb4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/272668 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-12T12:22:29Z

Message from 6543:

Patch Set 8:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-12T12:26:21Z

Message from Emmanuel Odeke:

Patch Set 8:

Thanks, but I was requesting you add them inside the code and not in the Godoc which would be an unnecessary explanation for the regular consumer. The comment inside the code is for maintainers and others peering deep, please change to the prior suggestion and add them in the related code sections as I had exhibited.

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

odeke-em · 2021-03-19T14:23:40Z

@6543 please take a look at, and address the feedback that I provided, then we’ll be ready to go. Thank you.

6543 · 2021-03-22T20:50:10Z

just had no time to allocate it to this :)
give me few minutes :)

Add IsPrivate() helper to check if an IP is private according to RFC 1918 & RFC 4193 Fixes golang#29146

6543 · 2021-03-22T21:09:01Z

@odeke-em hope, I got it right this time 🚀

gopherbot · 2021-03-22T21:11:57Z

Message from 6543:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-22T21:12:09Z

This PR (HEAD: 09f4ba7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/272668 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-22T21:14:10Z

Message from 6543:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-22T21:20:41Z

Message from Emmanuel Odeke:

Patch Set 10: Run-TryBot+1 Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-22T21:20:42Z

Message from Go Bot:

Patch Set 10:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=f77a2cf4

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

odeke-em · 2021-03-22T21:27:50Z

@6543 you got it, congrats and thank you!

Adds a new method IsPrivate to check if an IP is private according to RFC 1918 & RFC 4193. Fixes #29146 Change-Id: If77b9e1746d86029df66ae9f18437b1f65a18b59 GitHub-Last-Rev: 09f4ba7 GitHub-Pull-Request: #42793 Reviewed-on: https://go-review.googlesource.com/c/go/+/272668 Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com> TryBot-Result: Go Bot <gobot@golang.org>

gopherbot · 2021-03-22T21:37:00Z

Message from Go Bot:

Patch Set 10: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/272668.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-22T21:39:06Z

This PR is being closed because golang.org/cl/272668 has been merged.

bl-ue · 2021-03-22T21:48:25Z

🎊 🎉 🚀

google-cla bot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Nov 24, 2020

google-cla bot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Nov 24, 2020

6543 mentioned this pull request Nov 24, 2020

net: add IP.IsPrivate (RFC 1918 & RFC 4193) #29146

Closed

sapk reviewed Jan 4, 2021

View reviewed changes

src/net/ip_test.go Outdated Show resolved Hide resolved

6543 force-pushed the net/IP.IsPrivate branch from c73fccc to 70091ec Compare January 5, 2021 01:33

6543 force-pushed the net/IP.IsPrivate branch from 70091ec to bb09bf6 Compare February 3, 2021 15:24

6543 force-pushed the net/IP.IsPrivate branch from bb09bf6 to 29178a0 Compare February 16, 2021 13:05

6543 force-pushed the net/IP.IsPrivate branch from 29178a0 to b0729da Compare February 24, 2021 14:18

6543 force-pushed the net/IP.IsPrivate branch from b0729da to 1c40030 Compare March 1, 2021 03:05

6543 force-pushed the net/IP.IsPrivate branch from 1c40030 to ad0bdb4 Compare March 12, 2021 12:17

net: add IP.IsPrivate

09f4ba7

Add IsPrivate() helper to check if an IP is private according to RFC 1918 & RFC 4193 Fixes golang#29146

6543 force-pushed the net/IP.IsPrivate branch from ad0bdb4 to 09f4ba7 Compare March 22, 2021 21:08

gopherbot closed this Mar 22, 2021

6543 deleted the net/IP.IsPrivate branch March 23, 2021 12:21

net: add IP.IsPrivate #42793

net: add IP.IsPrivate #42793

Conversation

6543 commented Nov 24, 2020 • edited by odeke-em Loading

google-cla bot commented Nov 24, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

6543 commented Nov 24, 2020

gopherbot commented Nov 24, 2020

gopherbot commented Nov 24, 2020

gopherbot commented Nov 24, 2020

gopherbot commented Nov 24, 2020

gopherbot commented Nov 24, 2020

bl-ue commented Dec 19, 2020

6543 commented Jan 3, 2021 • edited Loading

bl-ue commented Jan 3, 2021

gopherbot commented Jan 5, 2021

gopherbot commented Feb 3, 2021

gopherbot commented Feb 16, 2021

gopherbot commented Feb 24, 2021

gopherbot commented Feb 26, 2021

gopherbot commented Feb 26, 2021

gopherbot commented Feb 26, 2021

gopherbot commented Feb 26, 2021

gopherbot commented Feb 26, 2021

gopherbot commented Mar 1, 2021

gopherbot commented Mar 11, 2021

gopherbot commented Mar 12, 2021

gopherbot commented Mar 12, 2021

gopherbot commented Mar 12, 2021

gopherbot commented Mar 12, 2021

gopherbot commented Mar 12, 2021

gopherbot commented Mar 12, 2021

odeke-em commented Mar 19, 2021

6543 commented Mar 22, 2021

6543 commented Mar 22, 2021

gopherbot commented Mar 22, 2021

gopherbot commented Mar 22, 2021

gopherbot commented Mar 22, 2021

gopherbot commented Mar 22, 2021

gopherbot commented Mar 22, 2021

odeke-em commented Mar 22, 2021

gopherbot commented Mar 22, 2021

gopherbot commented Mar 22, 2021

bl-ue commented Mar 22, 2021

6543 commented Nov 24, 2020 •

edited by odeke-em

Loading

6543 commented Jan 3, 2021 •

edited

Loading