Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bufio: add Reader.DiscardRune(n int) #47640

Closed
wants to merge 1 commit into from
Closed

bufio: add Reader.DiscardRune(n int) #47640

wants to merge 1 commit into from

Conversation

cafra
Copy link

@cafra cafra commented Aug 11, 2021

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.

Fixes #47621

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Aug 11, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 1e8c723) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/341390 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/341390.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Code-Review-2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/341390.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ansiz:

Patch Set 1: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/341390.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Martin Möhrmann:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/341390.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: b73baa6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/341390 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 80ac175) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/341390 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

   utf8: DecodeRune add the variable parameter parameters,The first parameter indicates that only the byte size of rune is returned

   more detail #47621

   Fixes #47621
@gopherbot
Copy link
Contributor

This PR (HEAD: 506a260) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/341390 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@mvdan
Copy link
Member

mvdan commented Dec 29, 2021

The proposal was retracted; closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: bufio: add Reader.DiscardRunes(n int) and utf8: add RuneByteLen
3 participants