Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/httputil: forward 1xx responses in ReverseProxy #53164

Closed
wants to merge 4 commits into from
Closed

net/http/httputil: forward 1xx responses in ReverseProxy #53164

wants to merge 4 commits into from

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented May 31, 2022 •
edited by dmitshur
Loading

Support for 1xx responses has recently been merged in
net/http (CL 269997).

As discussed in this CL
(https://go-review.googlesource.com/c/go/+/269997/comments/1ff70bef_c25a829a),
support for forwarding 1xx responses in ReverseProxy has been extracted
in this separate patch.

According to RFC 7231, "a proxy MUST forward 1xx responses unless the
proxy itself requested the generation of the 1xx response".
Consequently, all received 1xx responses are automatically forwarded as long as the
underlying transport supports ClientTrace.Got1xxResponse.

Fixes #26088
Fixes #51914

@gopherbot
Copy link
Contributor

This PR (HEAD: 902f8a7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/409536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@dunglas dunglas force-pushed the feat/1xx-reverse-proxy branch from 902f8a7 to aa23135 Compare May 31, 2022 17:26
@gopherbot
Copy link
Contributor

This PR (HEAD: aa23135) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/409536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@dunglas dunglas mentioned this pull request May 31, 2022
Closed
@gopherbot
Copy link
Contributor

Message from Rhys Hiltner:

Patch Set 2: Run-TryBot+1 Code-Review+1

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 3f2415f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/409536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Kévin Dunglas:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@dunglas dunglas force-pushed the feat/1xx-reverse-proxy branch 2 times, most recently from 4fe9581 to 30ee65f Compare July 12, 2022 07:31
@gopherbot
Copy link
Contributor

This PR (HEAD: 30ee65f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/409536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@dunglas dunglas mentioned this pull request Jul 12, 2022
Merged
@dunglas dunglas force-pushed the feat/1xx-reverse-proxy branch from 30ee65f to c3fe318 Compare August 8, 2022 20:44
@gopherbot
Copy link
Contributor

Message from Kévin Dunglas:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 7a6b718) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/409536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 5: Run-TryBot+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 5: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@dmitshur dmitshur changed the title net/http: reverseproxy: forward 1xx responses net/http/httputil: forward 1xx responses in ReverseProxy Aug 17, 2022
@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 6: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

dunglas added 2 commits August 30, 2022 12:16
@dunglas
net/http: reverseproxy: forward 1xx responses
d440d19 
Support for 1xx responses has recently been merged in
net/http (golang#42597).

As discussed in this CL
(https://go-review.googlesource.com/c/go/+/269997/comments/1ff70bef_c25a829a),
support for forwarding 1xx responses in ReverseProxy has been extracted
in this separate patch.

According to RFC 7231, "a proxy MUST forward 1xx responses unless the
proxy itself requested the generation of the 1xx response".
Consequently, all received 1xx responses are automatically forwarded as long as the
underlying transport supports ClientTrace.Got1xxResponse.

Fixes golang#26088
Fixes golang#51914
@dunglas
fix review
c3d0e2a
@dunglas dunglas force-pushed the feat/1xx-reverse-proxy branch from 7a6b718 to dab8a46 Compare August 30, 2022 10:17
@gopherbot
Copy link
Contributor

This PR (HEAD: dab8a46) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/409536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Kévin Dunglas:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from hopehook:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 7: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/409536.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 15, 2022
@dunglas @gopherbot
net/http/httputil: forward 1xx responses in ReverseProxy
972870d 
Support for 1xx responses has recently been merged in
net/http (CL 269997).

As discussed in this CL
(https://go-review.googlesource.com/c/go/+/269997/comments/1ff70bef_c25a829a),
support for forwarding 1xx responses in ReverseProxy has been extracted
in this separate patch.

According to RFC 7231, "a proxy MUST forward 1xx responses unless the
proxy itself requested the generation of the 1xx response".
Consequently, all received 1xx responses are automatically forwarded as long as the
underlying transport supports ClientTrace.Got1xxResponse.

Fixes #26088
Fixes #51914

Change-Id: I3a35ea023b798bfe56b7fb8696d5a49695229cfd
GitHub-Last-Rev: dab8a46
GitHub-Pull-Request: #53164
Reviewed-on: https://go-review.googlesource.com/c/go/+/409536
Reviewed-by: Damien Neil <dneil@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Rhys Hiltner <rhys@justin.tv>
Run-TryBot: hopehook <hopehook@golangcn.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/409536 has been merged.

@gopherbot gopherbot closed this Sep 15, 2022
@dunglas dunglas mentioned this pull request Oct 20, 2022
Open
@WeidiDeng WeidiDeng mentioned this pull request Jan 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net/http: support for the 103 status code net/http/httputil: make ReverseProxy forward 1xx responses
2 participants
@dunglas @gopherbot