testing: skip parallel tests when -failfast is enabled #53460
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The t.Parallel method does not interact well with the -failfast flag.
See #30522.
With
-failfast
enabled tests blocking ont.Parallel()
can be skippedafter the first test failure.
This won't immediately kill any parallel tests which are already running
but it will prevent more tests from starting.
I've chosen to use
t.SkipNow()
when we detect that we want to failfastafter a parallel test wakes up.
This to me seemed like the cleanest solution and doesn't hide
what is happening.
Though arguably we could print a more detailed message?
Fixes #30522