Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Resolves #147 - Including binaries with tagged releases via GoReleaser #229

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Resolves #147 - Including binaries with tagged releases via GoReleaser #229

merged 2 commits into from
Nov 20, 2019

Conversation

scevallos
Copy link
Contributor

GoReleaser provides an easy way to automate releases via a single config YAML. You can see what the result would look like on my fork's releases. The maintainers of this repo would have to generate a valid GitHub Token and set it as an envvar as specified here. This step can also be integrated with Travis, if the maintainers want to do that.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@scevallos
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@scevallos scevallos changed the title Addressing #147 - Including binaries with tagged releases via GoReleaser Fixes #147 - Including binaries with tagged releases via GoReleaser Nov 22, 2018
@scevallos scevallos changed the title Fixes #147 - Including binaries with tagged releases via GoReleaser Resolves #147 - Including binaries with tagged releases via GoReleaser Nov 22, 2018
@poy poy self-assigned this Sep 27, 2019
Copy link
Collaborator

@poy poy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this and sorry for the delay! If you're still interested, I would love to get this in.

One nit and one question.

.goreleaser.yml Show resolved Hide resolved
.goreleaser.yml Show resolved Hide resolved
@kishaningithub
Copy link
Contributor

kishaningithub commented Oct 11, 2019

@poy @scevallos I am also thinking if we could also use godownloader installation would become totally cool. This tool generates an installation script that you can check in into this repo. This installation script takes care of detecting the host platform and installing the appropriate binary. An example would be gosec

@codyoss
Copy link
Member

codyoss commented Oct 18, 2019

Fixes: #147

@scevallos scevallos requested a review from poy October 21, 2019 03:28
@codyoss
Copy link
Member

codyoss commented Nov 20, 2019

LGTM, Thanks for your contribution @scevallos 🎆

@codyoss codyoss merged commit 3fae808 into golang:master Nov 20, 2019
@codyoss codyoss mentioned this pull request Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants