-
Notifications
You must be signed in to change notification settings - Fork 607
Resolves #147 - Including binaries with tagged releases via GoReleaser #229
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this and sorry for the delay! If you're still interested, I would love to get this in.
One nit and one question.
@poy @scevallos I am also thinking if we could also use godownloader installation would become totally cool. This tool generates an installation script that you can check in into this repo. This installation script takes care of detecting the host platform and installing the appropriate binary. An example would be gosec |
Fixes: #147 |
LGTM, Thanks for your contribution @scevallos 🎆 |
GoReleaser provides an easy way to automate releases via a single config YAML. You can see what the result would look like on my fork's releases. The maintainers of this repo would have to generate a valid GitHub Token and set it as an envvar as specified here. This step can also be integrated with Travis, if the maintainers want to do that.