This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, is there any progress on this PR? |
Hey, any updates here? cc @codyoss |
any progress on this? |
Hey @codyoss , is there anything @n0trace/we/anyone can do to help get this PR reviewed and approved? |
add new flag in readme? |
cc @codyoss |
@codyoss Is any ETA for review of the PR? |
Would love to see this reviewed. Putting the feature behind a new flag seems like a good way to introduce it. |
/ping |
Bump. This would be very useful. |
cc @codyoss |
hi @n0trace , this also requires one additional fix for optional vars. Example interface: import (
"context"
"fmt"
"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/config"
"github.com/aws/aws-sdk-go-v2/service/s3"
)
type s3Client interface {
HeadBucket(ctx context.Context, input *s3.HeadBucketInput, opts ...func(*s3.Options)) (*s3.HeadBucketOutput, error)
} will generate incorrect mock Return func: Thanks |
@codyoss can anyone review this PR? |
Good news: Codyoss' github is highly active. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.