-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dns/dnsmessage: allow name compression for SRV resource parsing #199
Conversation
This PR (HEAD: e0993e9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/540375. Important tips:
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/540375. |
This PR (HEAD: 0267b9a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/540375. Important tips:
|
Message from Damien Neil: Patch Set 2: Code-Review+2 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/540375. |
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/540375. |
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/540375. |
Message from Heschi Kreinick: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/540375. |
Message from Mateusz Poliwczak: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/540375. |
Message from Carlos Amedee: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/540375. |
0267b9a
to
88d2e06
Compare
This PR (HEAD: 88d2e06) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/540375. Important tips:
|
As per RFC 3597: Receiving servers MUST decompress domain names in RRs of well-known type, and SHOULD also decompress RRs of type RP, AFSDB, RT, SIG, PX, NXT, NAPTR, and SRV (although the current specification of the SRV RR in RFC2782 prohibits compression, RFC2052 mandated it, and some servers following that earlier specification are still in use). This change allows SRV resource decompression. Updates golang/go#36718 Updates golang/go#37362 Change-Id: I473c0d3803758e5b12886f378d2ed54bd5392144 GitHub-Last-Rev: 88d2e06 GitHub-Pull-Request: #199 Reviewed-on: https://go-review.googlesource.com/c/net/+/540375 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Auto-Submit: Damien Neil <dneil@google.com> Reviewed-by: Damien Neil <dneil@google.com>
This PR is being closed because golang.org/cl/540375 has been merged. |
As per RFC 3597:
Receiving servers MUST decompress domain names in RRs of well-known
type, and SHOULD also decompress RRs of type RP, AFSDB, RT, SIG, PX,
NXT, NAPTR, and SRV (although the current specification of the SRV RR
in RFC2782 prohibits compression, RFC2052 mandated it, and some
servers following that earlier specification are still in use).
This change allows SRV resource decompression.
Updates golang/go#36718
Updates golang/go#37362