Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthCodeURL generates incomplete scopes #119

Closed
jimzhan opened this issue May 4, 2015 · 1 comment
Closed

AuthCodeURL generates incomplete scopes #119

jimzhan opened this issue May 4, 2015 · 1 comment

Comments

@jimzhan
Copy link

jimzhan commented May 4, 2015

oauth2.go, line 117, the scopes simply joined by spaces, instead of commas Github.

"scope":         internal.CondVal(strings.Join(c.Scopes, " ")),
@jimzhan jimzhan changed the title AuthCodeURL generates incorrect scopes AuthCodeURL generates incomplete scopes May 4, 2015
@adg
Copy link
Contributor

adg commented May 5, 2015

GitHub is wrong. Quoth the spec:

The value of the scope parameter is expressed as a list of space-
delimited, case-sensitive strings.

https://tools.ietf.org/html/rfc6749#section-3.3

When authenticating with GitHub, provide your scopes as a single comma-separated value.

@adg adg closed this as completed May 5, 2015
@walle walle mentioned this issue Oct 17, 2018
Closed
gopherbot pushed a commit that referenced this issue Oct 17, 2018
@walle @bradfitz
Add Zoho to the list of broken providers
9dcd33a 
As per the documentation https://www.zoho.com/crm/help/api/v2/#generate-access

The oauth2 implementation for Zoho is broken in other ways as well, e.g. by having scopes comma separated instead of space separated as the standard says. But won't (and shouldn't) be handled by this project as per #119.

Change-Id: I450391ac92cbb02e6ba6a21e4afcc4dd0d6849b4
GitHub-Last-Rev: ba758b0
GitHub-Pull-Request: #333
Reviewed-on: https://go-review.googlesource.com/c/142880
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimzhan @adg