google/externalaccount: moves externalaccount package out of internal and exports it #690

aeitzman · 2023-12-18T17:42:11Z

go/programmable-auth-design for context. Adds support for user defined
supplier methods to return subject tokens and AWS security credentials.

gopherbot · 2023-12-18T17:49:13Z

This PR (HEAD: 82aa92e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-18T17:56:28Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-09T18:42:23Z

Message from Chris Smith:

Patch Set 2:

(13 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-09T21:51:34Z

This PR (HEAD: 0d06665) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-17T00:27:20Z

This PR (HEAD: 85ffd02) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-17T18:02:31Z

Message from Alex Eitzman:

Patch Set 5:

(13 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-18T19:26:38Z

This PR (HEAD: c1ac924) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-18T23:10:27Z

Message from Leo Siracusa:

Patch Set 6:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-19T18:17:59Z

This PR (HEAD: c22d2a1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-19T18:45:44Z

Message from Alex Eitzman:

Patch Set 7:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-19T22:39:06Z

Message from Leo Siracusa:

Patch Set 7: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-22T22:06:00Z

This PR (HEAD: 7eef773) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-22T23:35:37Z

Message from Chris Smith:

Patch Set 8:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-23T22:54:41Z

This PR (HEAD: e15136c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-23T23:08:18Z

Message from Alex Eitzman:

Patch Set 9:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-23T23:48:46Z

This PR (HEAD: fc72581) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-24T00:08:48Z

Message from Chris Smith:

Patch Set 10: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-24T17:53:22Z

Message from Alex Eitzman:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T20:32:39Z

Message from Chris Smith:

Patch Set 22:

(11 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T22:25:10Z

This PR (HEAD: 362176f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-22T22:32:07Z

This PR (HEAD: ac519b2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-22T22:38:30Z

Message from Alex Eitzman:

Patch Set 23:

(11 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T00:37:14Z

Message from Chris Smith:

Patch Set 24: Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T15:00:58Z

Message from Cody Oss:

Patch Set 24: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T15:07:57Z

Message from Gopher Robot:

Patch Set 24:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T15:07:57Z

Message from Cody Oss:

Patch Set 24:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T15:07:58Z

Message from Gopher Robot:

Patch Set 24: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T18:21:47Z

Message from Alex Eitzman:

Patch Set 25:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T18:21:48Z

Message from Alex Eitzman:

Patch Set 25:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T21:31:51Z

Message from Alex Eitzman:

Patch Set 25:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T22:09:33Z

Message from Cody Oss:

Patch Set 25: Auto-Submit+1 Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T19:40:54Z

Message from Cody Oss:

Patch Set 25: -Auto-Submit -Run-TryBot

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T19:40:54Z

Message from Cody Oss:

Patch Set 25: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T20:55:48Z

Message from Cody Oss:

Patch Set 25: -Run-TryBot Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T21:01:58Z

Message from Go LUCI:

Patch Set 25:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-27T20:48:02Z","revision":"481dd9eba5f60ee7d4e4bf0f145bf66855d25611"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T21:01:59Z

Message from Cody Oss:

Patch Set 25: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T21:01:59Z

Message from Go LUCI:

Patch Set 25:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T21:02:00Z

Message from Go LUCI:

Patch Set 25: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/550835.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T22:04:46Z

This PR is being closed because golang.org/cl/550835 has been merged.

… and exports it go/programmable-auth-design for context. Adds support for user defined supplier methods to return subject tokens and AWS security credentials. Change-Id: I7bc41f8c5202ae933fce516632f5049bbeb3d378 GitHub-Last-Rev: ac519b2 GitHub-Pull-Request: #690 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/550835 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Leo Siracusa <leosiracusa@google.com> Reviewed-by: Chris Smith <chrisdsmith@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cody Oss <codyoss@google.com>

* google: add UniverseDomain to CredentialsParams Change-Id: I7925b8341e1f047d0115acd7a01a34679a489ee0 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/552716 Reviewed-by: Cody Oss <codyoss@google.com> Run-TryBot: Cody Oss <codyoss@google.com> Reviewed-by: Viacheslav Rostovtsev <virost@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> * google: add Credentials.GetUniverseDomain with GCE MDS support * Deprecate Credentials.UniverseDomain Change-Id: I1cbc842fbfce35540c8dff99fec09e036b9e2cdf Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/554215 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Cody Oss <codyoss@google.com> Auto-Submit: Cody Oss <codyoss@google.com> Reviewed-by: Cody Oss <codyoss@google.com> Reviewed-by: Viacheslav Rostovtsev <virost@google.com> * go.mod: update golang.org/x dependencies Update golang.org/x dependencies to their latest tagged versions. Change-Id: Icf68cb33585a13df206afacdb79832ea76f82346 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/554676 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Than McIntosh <thanm@google.com> Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> * google/downscope: add DownscopingConfig.UniverseDomain to support TPC Change-Id: I3669352b382414ea640ca176afa4071995fc5ff1 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/557135 Reviewed-by: Cody Oss <codyoss@google.com> TryBot-Bypass: Cody Oss <codyoss@google.com> Auto-Submit: Cody Oss <codyoss@google.com> * google/internal/externalaccount: update serviceAccountImpersonationRE to support universe domain Change-Id: Iafe35c293209bd88997c876341ebde7ac9ecda93 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/557195 TryBot-Bypass: Cody Oss <codyoss@google.com> Reviewed-by: Cody Oss <codyoss@google.com> Auto-Submit: Cody Oss <codyoss@google.com> * go.mod: update golang.org/x dependencies Update golang.org/x dependencies to their latest tagged versions. Change-Id: I8228a126b322fb14250bbb5933199ce45e8584d3 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/562496 Reviewed-by: Than McIntosh <thanm@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Gopher Robot <gobot@golang.org> * google/externalaccount: moves externalaccount package out of internal and exports it go/programmable-auth-design for context. Adds support for user defined supplier methods to return subject tokens and AWS security credentials. Change-Id: I7bc41f8c5202ae933fce516632f5049bbeb3d378 GitHub-Last-Rev: ac519b2 GitHub-Pull-Request: golang#690 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/550835 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Leo Siracusa <leosiracusa@google.com> Reviewed-by: Chris Smith <chrisdsmith@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cody Oss <codyoss@google.com> * google/externalaccount: add Config.UniverseDomain Change-Id: Ia1caee246da68c01addd06e1367ed1e43645826b Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/568216 Reviewed-by: Alex Eitzman <eitzman@google.com> Reviewed-by: Cody Oss <codyoss@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> * go.mod: update golang.org/x dependencies Update golang.org/x dependencies to their latest tagged versions. Change-Id: I993c77edbea8426f558ab84c4ba769e0bdf6406d Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/568935 Reviewed-by: Than McIntosh <thanm@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com> --------- Co-authored-by: Chris Smith <chrisdsmith@google.com> Co-authored-by: Gopher Robot <gobot@golang.org> Co-authored-by: aeitzman <eitzman@google.com>

… and exports it go/programmable-auth-design for context. Adds support for user defined supplier methods to return subject tokens and AWS security credentials. Change-Id: I7bc41f8c5202ae933fce516632f5049bbeb3d378 GitHub-Last-Rev: ac519b2 GitHub-Pull-Request: golang#690 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/550835 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Leo Siracusa <leosiracusa@google.com> Reviewed-by: Chris Smith <chrisdsmith@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cody Oss <codyoss@google.com>

Adding programattic refreshable credentials

82aa92e

aeitzman changed the title ~~Adds support for user defined subject token suppliers for AWS and Identity Pool Credentials.~~ google/internal/externalaccount: Adds support for user defined subject token suppliers for AWS and Identity Pool Credentials. Dec 18, 2023

aeitzman changed the title ~~google/internal/externalaccount: Adds support for user defined subject token suppliers for AWS and Identity Pool Credentials.~~ google/internal/externalaccount: Adds support for user defined subject token suppliers for AWS and Identity Pool Credentials Dec 18, 2023

Addressing PR comments

0d06665

aeitzman changed the title ~~google/internal/externalaccount: Adds support for user defined subject token suppliers for AWS and Identity Pool Credentials~~ google/internal/externalaccount: adds support for user defined subject token suppliers for AWS and Identity Pool Credentials Jan 9, 2024

Using struct for AWS supplier to better match java implementation

85ffd02

moving externalaccount package out of internal

c1ac924

Responding to CL comments

c22d2a1

Merge remote-tracking branch 'origin/master' into programmatic-auth

7eef773

responding to CL comments

e15136c

fix test

fc72581

Adding docs

89498bd

aeitzman added 2 commits February 22, 2024 14:19

Respond to comments

353e887

fix typo

362176f

fix type

ac519b2

aeitzman changed the title ~~google/internal/externalaccount: adds support for user defined subject token suppliers for AWS and Identity Pool Credentials~~ google/externalaccount: moves externalaccount package out of internal and exports it. Feb 26, 2024

aeitzman changed the title ~~google/externalaccount: moves externalaccount package out of internal and exports it.~~ google/externalaccount: moves externalaccount package out of internal and exports it Feb 26, 2024

gopherbot closed this Feb 27, 2024

google/externalaccount: moves externalaccount package out of internal and exports it #690

google/externalaccount: moves externalaccount package out of internal and exports it #690

Conversation

aeitzman commented Dec 18, 2023 • edited Loading

gopherbot commented Dec 18, 2023

gopherbot commented Dec 18, 2023

gopherbot commented Jan 9, 2024

gopherbot commented Jan 9, 2024

gopherbot commented Jan 17, 2024

gopherbot commented Jan 17, 2024

gopherbot commented Jan 18, 2024

gopherbot commented Jan 18, 2024

gopherbot commented Jan 19, 2024

gopherbot commented Jan 19, 2024

gopherbot commented Jan 19, 2024

gopherbot commented Jan 22, 2024

gopherbot commented Jan 22, 2024

gopherbot commented Jan 23, 2024

gopherbot commented Jan 23, 2024

gopherbot commented Jan 23, 2024

gopherbot commented Jan 24, 2024

gopherbot commented Jan 24, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

aeitzman commented Dec 18, 2023 •

edited

Loading