Skip to content

Commit

Permalink
Revert "static/frontend: made cancel button in search field keyboard …
Browse files Browse the repository at this point in the history
…accessible"

This reverts commit a224e84.

Reason for revert: breaks the UI (#68538)

Fixes #68538.

Change-Id: I23a6acaf741e7cb863c304363ee9b7a4fdf0bbe2
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/608036
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
  • Loading branch information
jba committed Aug 24, 2024
1 parent 1dda386 commit 9b36df4
Show file tree
Hide file tree
Showing 8 changed files with 6 additions and 34 deletions.
2 changes: 1 addition & 1 deletion devtools/docker/compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ services:
# time seeddb runs. If this ends up being flaky, we should add a check here.
command: bash -c "
echo GO_DISCOVERY_CONFIG_DYNAMIC=$GO_DISCOVERY_CONFIG_DYNAMIC &&
go run ./devtools/cmd/wait_available --timeout 300s db:5432 --
GODEBUG=cmdgonetlimit=64 go run ./devtools/cmd/wait_available --timeout 300s db:5432 --
go run ./devtools/cmd/db/main.go create &&
go run ./devtools/cmd/db/main.go migrate &&
go run ./devtools/cmd/seeddb/main.go -seed ${GO_DISCOVERY_SEED_DB_FILE:-seed.txt}"
Expand Down
28 changes: 0 additions & 28 deletions static/frontend/homepage/homepage.css
Original file line number Diff line number Diff line change
Expand Up @@ -88,34 +88,6 @@
}
}

.Homepage-closeIcon {
background: var(--color-input);
border-bottom: var(--border);
border-color: var(--color-brand-primary);
border-left: 0;
border-top: var(--border);
color: var(--color-button);
cursor: pointer;
display: inline-block;
font-weight: bold;
padding-left: 0.5rem;
padding-right: 0.5rem;
}

.Homepage-closeIcon:hover,
.Homepage-closeIcon:focus,
.Homepage-closeIcon:focus-within,
.Homepage-closeIcon:active {
border-left: 0 !important;
}

.Homepage-search--input:hover,
.Homepage-search--input:focus,
.Homepage-search--input:focus-within,
.Homepage-search--input:active {
border-right: 0 !important;
}

input[type='search']::-webkit-search-decoration {
display: none;
}
Expand Down
2 changes: 1 addition & 1 deletion static/frontend/homepage/homepage.min.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions static/frontend/homepage/homepage.min.css.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions static/frontend/homepage/homepage.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@
<form class="go-InputGroup Homepage-search Homepage-search--symbol"
action="/search" role="search" data-gtmc="homepage search form">
<input
class="go-Input js-searchFocus Homepage-search--input"
class="go-Input js-searchFocus"
data-test-id="homepage-search"
id="AutoComplete"
role="textbox"
aria-label="{{.SearchPrompt}}"
type="search"
name="q"
placeholder="{{.SearchPrompt}}"
autocapitalize="off"
Expand All @@ -29,7 +30,6 @@
spellcheck="false"
title="{{.SearchPrompt}}"
autofocus="true">
<button class="Homepage-closeIcon" type="reset" aria-label="Clear Search"> X </button>
<button type="submit" class="go-Button">Search</button>
</form>
<section class="go-Carousel Homepage-tips js-carousel" aria-label="Search Tips Carousel" data-slide-index="{{.TipIndex}}">
Expand Down
Binary file modified tests/screentest/testdata/home-540x1080.a.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/screentest/testdata/home.a.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/screentest/testdata/no-documentation.a.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 9b36df4

Please sign in to comment.