Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-go: use standard library context (requires Go1.9) #548

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

dsnet
Copy link
Member

@dsnet dsnet commented Mar 8, 2018

This change effectively makes Go1.9 the minimum required version of Go
when using gRPC since type aliases are needed to truly unify context.
Even though this only affects those who use gRPC, there are other reasons we
need Go1.9 (such as type aliases for import public).

Fixes #537

This change effectively makes Go1.9 the minimum required version of Go
when using gRPC since type aliases are needed to truly unify context.
Even though this only affects those who use gRPC, there are other reasons we
need Go1.9 (such as type aliases for import public).

Fixes #537
@dsnet dsnet requested a review from neild March 8, 2018 02:36
@dsnet
Copy link
Member Author

dsnet commented Mar 8, 2018

Even though AppEngine classic is still not on Go1.9, it should happen by the time we merge dev into master (#479).

@neild
Copy link
Contributor

neild commented Mar 8, 2018

This doesn't make Go 1.9 the minimum unless you need to mix code which uses "golang.org/x/net/context" and "context". If you consistently use one or the other, there's no need for an alias.

@dsnet dsnet merged commit 3dc8a89 into dev Mar 8, 2018
@dsnet dsnet deleted the dev-context branch March 8, 2018 21:32
@dfawley
Copy link
Contributor

dfawley commented Apr 2, 2018

This doesn't make Go 1.9 the minimum unless you need to mix code which uses
"golang.org/x/net/context" and "context". If you consistently use one or the
other, there's no need for an alias.

gRPC-Go imports x/net/context, so yes, this does make Go 1.9 the minimum version supportable by gRPC-Go. This is not OK for us.

dsnet pushed a commit that referenced this pull request Apr 13, 2018
@golang golang locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants