-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys/windows: add serial comm functions #187
Conversation
This PR (HEAD: d7891e9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/572295. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Tom Payne: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Alex Brainman: Patch Set 1: Code-Review+2 (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Serial ports are still widely used to communicate with a large range of devices. This change adds the remaining functions described in "Serial Communications in Win32", enabling Go applications and libraries to be written that support the full set of serial port functionality on Windows. x/sys/unix already has equivalent functionality through termios. See https://learn.microsoft.com/en-us/previous-versions/ms810467(v=msdn.10).
This PR (HEAD: 31cfda2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/572295. Important tips:
|
Message from Tom Payne: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Tom Payne: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Tom Payne: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Emmanuel Odeke: Patch Set 3: Commit-Queue+1 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-28T04:07:31Z","revision":"978f67f591a0cecc60669d38f7df897c99e71b5a"} Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Emmanuel Odeke: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Go LUCI: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/x_sys-go1.22-windows-amd64 has failed with summary (view all results): FAILURE
Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Gopher Robot: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Gopher Robot: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Gopher Robot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Alex Brainman: Patch Set 3: Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-28T20:27:58Z","revision":"978f67f591a0cecc60669d38f7df897c99e71b5a"} Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Alex Brainman: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Alex Brainman: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Alex Brainman: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Tom Payne: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Alex Brainman: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
This PR (HEAD: 0a5a744) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/572295. Important tips:
|
Message from Tom Payne: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Alex Brainman: Patch Set 4: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-01T02:11:10Z","revision":"7dadd1c4f7e5ccbeaccd071dfee2c9eca1105bdd"} Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Alex Brainman: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Alex Brainman: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from Than McIntosh: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Message from David Chase: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572295. |
Serial ports are still widely used to communicate with a large range of devices. This change adds the remaining functions described in "Serial Communications in Win32", enabling Go applications and libraries to be written that support the full set of serial port functionality on Windows. x/sys/unix already has equivalent functionality through termios. See https://learn.microsoft.com/en-us/previous-versions/ms810467(v=msdn.10). Change-Id: I57f9ed6b7dbcc2331f740bd95b6483f141b0ad6f GitHub-Last-Rev: 0a5a744 GitHub-Pull-Request: #187 Reviewed-on: https://go-review.googlesource.com/c/sys/+/572295 Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
This PR is being closed because golang.org/cl/572295 has been merged. |
Serial ports are still widely used to communicate with a large range of
devices.
This change adds the remaining functions described in "Serial
Communications in Win32", enabling Go applications and libraries to be
written that support the full set of serial port functionality on
Windows.
x/sys/unix already has equivalent functionality through termios.
See https://learn.microsoft.com/en-us/previous-versions/ms810467(v=msdn.10).