-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: add console codepage api #206
Conversation
This PR (HEAD: 2c38ffb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/599395. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. |
Message from Ayman Bagabas: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. |
Message from Alex Brainman: Patch Set 1: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. |
2c38ffb
to
93c06e2
Compare
This PR (HEAD: 93c06e2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/599395. Important tips:
|
Message from Ayman Bagabas: Patch Set 2: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. |
Add setter/getter for console input/output codepages. This is useful to set the console expected codepage instead of converting it to UTF-16 before writing.
Message from Alex Brainman: Patch Set 2: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-27T10:34:06Z","revision":"d97c91d9ac8334c030ae09bf145da97fe11a5bb9"} Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. |
Message from Alex Brainman: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. |
Message from Alex Brainman: Patch Set 2: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. |
Message from Michael Pratt: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. |
Message from Cherry Mui: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. |
Add setter/getter for console input/output codepages. This is useful to set the console expected codepage instead of converting it to UTF-16 before writing. Change-Id: Ie0465708e7cf68d776e23dbbeeca7bcb4db7d2bf GitHub-Last-Rev: 93c06e2 GitHub-Pull-Request: #206 Reviewed-on: https://go-review.googlesource.com/c/sys/+/599395 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Michael Pratt <mpratt@google.com>
This PR is being closed because golang.org/cl/599395 has been merged. |
Add setter/getter for console input/output codepages. This is useful to set the console expected codepage instead of converting it to UTF-16 before writing.