Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src/goEnvironmentStatus: fix PATH mutation logic in osx
I misuderstood the comment in microsoft/vscode#99878 (comment) which resulted in that the PATH change does not apply with the default shell args settings in OS X. As noted in #544 (comment) VS Code sets `-l` as the default shell arg. I also attempted to run updateIntegratedTerminal after running environmentVariableCollection.prepend. But it seems like the onDidOpenTerminal handler is not invoked when VS Code relaunches the terminals to apply the environmentVariableCollection changes. Tested manually with "terminal.integrated.shellArgs.osx": [] and without the setting. Fixes #544 Change-Id: Icbaaa5131893038f85e322bad1491a99f26378fd Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/251161 Reviewed-by: Suzy Mueller <suzmue@golang.org>
- Loading branch information