Skip to content

Commit

Permalink
src/utils/pathUtils: return the default go path only if exists
Browse files Browse the repository at this point in the history
https://go-review.googlesource.com/c/vscode-go/+/276493 meant
to add /usr/local/bin/go to the default path to search, but introduced
a bug - we shouldn't return the path if the go binary doesn't exist.

TODO: This function got complicated over time and deserves proper testing.

For #971
Fixes #1065

Change-Id: I3ddf90983a1f66d6d76a3f9a50eb528a93904f3c
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/279727
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
  • Loading branch information
hyangah committed Dec 28, 2020
1 parent 0abde47 commit dd9c54f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/utils/pathUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ export function getBinPathWithPreferredGopathGorootWithExplanation(
for (const p of defaultPathsForGo) {
if (executableFileExists(p)) {
binPathCache[toolName] = p;
return {binPath: p, why: 'default'};
}
return {binPath: p, why: 'default'};
}
return {binPath: ''};
}
Expand Down

0 comments on commit dd9c54f

Please sign in to comment.