-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goInstallTools: support installation of go #253
Comments
Change https://golang.org/cl/239597 mentions this issue: |
This CL is the third in a series which should follow this general outline: 1. Create status bar item for switching Go binary (not implemented) 2. Create command palette menu for choosing the Go binary 3. Track the currently selected Go binary using workspace context 4. Show versions of Go that are not installed and allow them to be selected and installed 5. Ensure new integrated terminals use the selected environment 6. Update workspace state to use settings.json instead 7. Detect if Go is not installed and prompt to install it 8. Detect if user has the latest version of Go installed and prompt them to install it 9. Cache Go paths upon extension initialization for faster menu loading This CL fetches Go versions from golang.org/dl and presents them as options in the command palette menu. Upon selection, the go binary is installed and set in the workspace state Updates #253 Change-Id: Ieb2b407f2149b016fbf88188ff94ee7cefe36671 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/239597 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
When there is no go command for use, how about presenting the link to golang.org/dl webpage in addition to the error message? /cc @mcjcloud |
Change https://golang.org/cl/242199 mentions this issue: |
This CL addresses item 7 in the following feature outline: 1. Create a status bar item which displays the current Go version 2. Create a variable for tracking the selected Go version and allow it to be updated by the command palette 3. Create a command palette menu which shows installed versions of Go 4. Show uninstalled versions of Go and allow them to be installed 5. Update workspace state to use settings.json instead 6. Ensure new integrated terminals are launched with the selected go binary 7. Detect if Go is not installed and prompt to install it 8. Detect if user has the latest version of Go installed and prompt them to install it 9. Cache results upon extension initialization to make the command palette menu render faster Specifically, this CL does a check for Go upon initialization of the extension. If it is not found, the user is prompted to go to the download page and the extension is not initialized. Updates #253 Change-Id: I94f932b29900ba4ce7a916ecb3274e4abd15ff6d Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/242199 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
All relevant cls by @mcjcloud are checked in. I will close this for now. |
If no go binary is found in the system, provide an option to download from dl.golang.org.
Additionally, offer a way to easily install/manage extra versions of go
https://golang.org/doc/install#extra_versions can be a starting point.
cc/ @mcjcloud
The text was updated successfully, but these errors were encountered: