Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go status bar: disappears when all files closed #831

Closed
stamblerre opened this issue Oct 23, 2020 · 3 comments
Closed

Go status bar: disappears when all files closed #831

stamblerre opened this issue Oct 23, 2020 · 3 comments
Assignees
@suzmue
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
v0.18.1

Comments

@stamblerre
Copy link
Contributor

Just noticed this--the extension should still be active so I wouldn't expect this to disappear.
@suzmue
Copy link
Contributor

suzmue commented Oct 23, 2020

The Go status bar is hidden when there is no active TextEditor.

Keeping the status bar visible when the Go extension is active seems like the right the thing to do.

@suzmue suzmue self-assigned this Oct 23, 2020
@suzmue suzmue added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 23, 2020
@hyangah hyangah added this to the v0.18.1 milestone Oct 23, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/265126 mentions this issue: src/goStatus: show Go status bar when the extension is enabled

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/266577 mentions this issue: [release] src/goStatus: show Go status bar when the extension is enabled

@hyangah hyangah mentioned this issue Oct 30, 2020
Closed
3 tasks
gopherbot pushed a commit that referenced this issue Oct 30, 2020
@suzmue @hyangah
[release] src/goStatus: show Go status bar when the extension is enabled
2ba9297 
We should be showing the Go status bar, even when there are no
active text editors.

Fixes #831

Change-Id: Ifb228b25f64ad41c7b63bdca27cf351768d8c4ce
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/265126
Trust: Suzy Mueller <suzmue@golang.org>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
(cherry picked from commit 5eaf73c)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/266577
Reviewed-by: Suzy Mueller <suzmue@golang.org>
@golang golang locked and limited conversation to collaborators Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@suzmue suzmue

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
v0.18.1
Development

No branches or pull requests
4 participants
@hyangah @stamblerre @suzmue @gopherbot