all: remove unit tests for staticcheck, unparam, and spellcheck

Those should not be unit tests and, more importantly, they should not be
running on builders.

Change-Id: I70504fedce3bad17ac408dc6f208d61fb7bd6071
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/587097
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

all_test.go

@@ -22,7 +22,6 @@ import (
 	"golang.org/x/mod/modfile"
 	"golang.org/x/vuln/internal/testenv"
 	"golang.org/x/vuln/scan"
-	"mvdan.cc/unparam/check"
 )
 
 // excluded contains the set of modules that x/vuln should not depend on.
@@ -83,22 +82,6 @@ func TestGovulncheck(t *testing.T) {
 	}
 }
 
-func TestStaticCheck(t *testing.T) {
-	skipIfShort(t)
-	rungo(t, "run", "honnef.co/go/tools/cmd/staticcheck@v0.4.3", "./...")
-}
-
-func TestUnparam(t *testing.T) {
-	testenv.NeedsGoBuild(t)
-	warns, err := check.UnusedParams(false, false, false, "./...")
-	if err != nil {
-		t.Fatalf("check.UnusedParams: %v", err)
-	}
-	for _, warn := range warns {
-		t.Errorf(warn)
-	}
-}
-
 func TestVet(t *testing.T) {
 	rungo(t, "vet", "-all", "./...")
 }
@@ -107,11 +90,6 @@ func TestGoModTidy(t *testing.T) {
 	rungo(t, "mod", "tidy")
 }
 
-func TestMisspell(t *testing.T) {
-	skipIfShort(t)
-	rungo(t, "run", "github.com/client9/misspell/cmd/misspell@v0.3.4", "-error", ".")
-}
-
 func TestHeaders(t *testing.T) {
 	sfs := os.DirFS(".")
 	fs.WalkDir(sfs, ".", func(path string, d fs.DirEntry, _ error) error {

go.mod

@@ -8,7 +8,6 @@ require (
 	golang.org/x/mod v0.17.0
 	golang.org/x/sync v0.7.0
 	golang.org/x/tools v0.21.1-0.20240514024235-59d9797072e7
-	mvdan.cc/unparam v0.0.0-20230312165513-e84e2d14e3b8
 )
 
 require github.com/google/renameio v0.1.0 // indirect

go.sum

@@ -9,9 +9,5 @@ golang.org/x/mod v0.17.0 h1:zY54UmvipHiNd+pm+m0x9KhZ9hl1/7QNMyxXbc6ICqA=
 golang.org/x/mod v0.17.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
 golang.org/x/sync v0.7.0 h1:YsImfSBoP9QPYL0xyKJPq0gcaJdG3rInoqxTWbfQu9M=
 golang.org/x/sync v0.7.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
-golang.org/x/tools v0.21.0 h1:qc0xYgIbsSDt9EyWz05J5wfa7LOVW0YTLOXrqdLAWIw=
-golang.org/x/tools v0.21.0/go.mod h1:aiJjzUbINMkxbQROHiO6hDPo2LHcIPhhQsa9DLh0yGk=
 golang.org/x/tools v0.21.1-0.20240514024235-59d9797072e7 h1:DnP3aRQn/r68glNGB8/7+3iE77jA+YZZCxpfIXx2MdA=
 golang.org/x/tools v0.21.1-0.20240514024235-59d9797072e7/go.mod h1:aiJjzUbINMkxbQROHiO6hDPo2LHcIPhhQsa9DLh0yGk=
-mvdan.cc/unparam v0.0.0-20230312165513-e84e2d14e3b8 h1:VuJo4Mt0EVPychre4fNlDWDuE5AjXtPJpRUWqZDQhaI=
-mvdan.cc/unparam v0.0.0-20230312165513-e84e2d14e3b8/go.mod h1:Oh/d7dEtzsNHGOq1Cdv8aMm3KdKhVvPbRQcM8WFpBR8=