Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/ElrondNetwork/elrond-go: CVE-2022-46173 #1200

Closed
GoVulnBot opened this issue Dec 28, 2022 · 4 comments
Assignees
Labels
excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module.

Comments

@GoVulnBot
Copy link

CVE-2022-46173 references github.com/ElrondNetwork/elrond-go, which may be a Go module.

Description:
Elrond-GO is a go implementation for the Elrond Network protocol. Versions prior to 1.3.50 are subject to a processing issue where nodes are affected when trying to process a cross-shard relayed transaction with a smart contract deploy transaction data. The problem was a bad correlation between the transaction caches and the processing component. If the above-mentioned transaction was sent with more gas than required, the smart contract result (SCR transaction) that should have returned the leftover gas, would have been wrongly added to a cache that the processing unit did not consider. The node stopped notarizing metachain blocks. The fix was actually to extend the SCR transaction search in all other caches if it wasn't found in the correct (expected) sharded-cache. There are no known workarounds at this time. This issue has been patched in version 1.3.50.

References:

Cross references:

See doc/triage.md for instructions on how to triage this report.

modules:
  - module: github.com/ElrondNetwork/elrond-go
    packages:
      - package: elrond-go
description: |
    Elrond-GO is a go implementation for the Elrond Network protocol. Versions prior to 1.3.50 are subject to a processing issue where nodes are affected when trying to process a cross-shard relayed transaction with a smart contract deploy transaction data. The problem was a bad correlation between the transaction caches and the processing component. If the above-mentioned transaction was sent with more gas than required, the smart contract result (SCR transaction) that should have returned the leftover gas, would have been wrongly added to a cache that the processing unit did not consider. The node stopped notarizing metachain blocks. The fix was actually to extend the SCR transaction search in all other caches if it wasn't found in the correct (expected) sharded-cache. There are no known workarounds at this time. This issue has been patched in version 1.3.50.
cves:
  - CVE-2022-46173
references:
  - web: https://github.com/ElrondNetwork/elrond-go/security/advisories/GHSA-p228-4mrh-ww7r
  - fix: https://github.com/ElrondNetwork/elrond-go/pull/4718
  - fix: https://github.com/ElrondNetwork/elrond-go/commit/39d7ddcb08bb34217dab6daef7cd9d287fb8cab3

@tatianab tatianab added the excluded: NOT_IMPORTABLE This vulnerability only exists in a binary and is not importable. label Dec 28, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/459639 mentions this issue: data/excluded: batch add GO-2022-1200

@tatianab tatianab added NeedsReport and removed excluded: NOT_IMPORTABLE This vulnerability only exists in a binary and is not importable. labels Dec 28, 2022
@tatianab tatianab self-assigned this Dec 28, 2022
@tatianab tatianab added excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module. and removed NeedsReport labels Dec 29, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/460419 mentions this issue: data/excluded: batch add GO-2022-1253, GO-2022-1251, GO-2022-1250, GO-2022-1248, GO-2022-1245, GO-2022-1243, GO-2022-1240, GO-2022-1239, GO-2022-1236, GO-2022-1235, GO-2022-1225, GO-2022-1220, GO-2022-1219, GO-2022-1218, GO-2022-1216, GO-2022-1208, GO-2022-1206, GO-2022-1204, GO-2022-1200, GO-2022-1192, GO-2022-1190, GO-2022-1189, GO-2022-1258, GO-2022-1226, GO-2022-1214, GO-2022-1210, GO-2022-1212

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/592835 mentions this issue: data/reports: unexclude 50 reports

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/607232 mentions this issue: data/reports: unexclude 20 reports (30)

gopherbot pushed a commit that referenced this issue Aug 21, 2024
  - data/reports/GO-2022-1160.yaml
  - data/reports/GO-2022-1161.yaml
  - data/reports/GO-2022-1164.yaml
  - data/reports/GO-2022-1171.yaml
  - data/reports/GO-2022-1179.yaml
  - data/reports/GO-2022-1181.yaml
  - data/reports/GO-2022-1189.yaml
  - data/reports/GO-2022-1190.yaml
  - data/reports/GO-2022-1191.yaml
  - data/reports/GO-2022-1192.yaml
  - data/reports/GO-2022-1200.yaml
  - data/reports/GO-2022-1204.yaml
  - data/reports/GO-2022-1205.yaml
  - data/reports/GO-2022-1206.yaml
  - data/reports/GO-2022-1208.yaml
  - data/reports/GO-2022-1212.yaml
  - data/reports/GO-2022-1215.yaml
  - data/reports/GO-2022-1216.yaml
  - data/reports/GO-2022-1217.yaml
  - data/reports/GO-2022-1218.yaml

Updates #1160
Updates #1161
Updates #1164
Updates #1171
Updates #1179
Updates #1181
Updates #1189
Updates #1190
Updates #1191
Updates #1192
Updates #1200
Updates #1204
Updates #1205
Updates #1206
Updates #1208
Updates #1212
Updates #1215
Updates #1216
Updates #1217
Updates #1218

Change-Id: I342a98eb3c967b16853089cb8f66a898af13b544
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/607232
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Tatiana Bradley <tatianabradley@google.com>
Commit-Queue: Tatiana Bradley <tatianabradley@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module.
Projects
None yet
Development

No branches or pull requests

3 participants