Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/turt2live/matrix-media-repo: GHSA-5crw-6j7v-xc72 #2053

Closed
GoVulnBot opened this issue Sep 8, 2023 · 3 comments
Labels
excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module.

Comments

@GoVulnBot
Copy link

In GitHub Security Advisory GHSA-5crw-6j7v-xc72, there is a vulnerability in the following Go packages or modules:

Unit Fixed Vulnerable Ranges
github.com/turt2live/matrix-media-repo 1.3.0 < 1.3.0

Cross references:
No existing reports found with this module or alias.

See doc/triage.md for instructions on how to triage this report.

modules:
    - module: github.com/turt2live/matrix-media-repo
      versions:
        - fixed: 1.3.0
      vulnerable_at: 1.2.13
      packages:
        - package: github.com/turt2live/matrix-media-repo
summary: 'matrix-media-repo: Unsafe media served inline on download endpoints'
description: |-
    ### Impact A malicious user can upload an SVG image containing JavaScript to
    their server. When matrix-media-repo is asked to serve that media via the
    `/_matrix/media/(r0|v3)/download` endpoint, it would be served with a
    `Content-Disposition` of `inline`. This can allow JavaScript to run in the
    browser if a client links to the `/download` endpoint directly.

    Server operators which do not share a domain between matrix-media-repo and other
    services are not affected, but are encouraged to upgrade regardless.

    ### Patches
    https://github.com/turt2live/matrix-media-repo/commit/77ec2354e8f46d5ef149d1dcaf25f51c04149137
    and
    https://github.com/turt2live/matrix-media-repo/commit/bf8abdd7a5371118e280c65a8e0ec2b2e9bdaf59
    fix the issue. Operators should upgrade to v1.3.0 as soon as possible.

    ### Workarounds The `Content-Disposition` header can be overridden by the
    reverse proxy in front of matrix-media-repo to always use `attachment`,
    defeating this issue at the cost of "worse" user experience when clicking
    download links.

    ### References https://developer.mozilla.org/en-US/docs/Web/SVG/Element/script
cves:
    - CVE-2023-41318
ghsas:
    - GHSA-5crw-6j7v-xc72
references:
    - advisory: https://github.com/turt2live/matrix-media-repo/security/advisories/GHSA-5crw-6j7v-xc72
    - fix: https://github.com/turt2live/matrix-media-repo/commit/77ec2354e8f46d5ef149d1dcaf25f51c04149137
    - fix: https://github.com/turt2live/matrix-media-repo/commit/bf8abdd7a5371118e280c65a8e0ec2b2e9bdaf59
    - web: https://developer.mozilla.org/en-US/docs/Web/SVG/Element/script
    - advisory: https://github.com/advisories/GHSA-5crw-6j7v-xc72

@tatianab tatianab added the excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module. label Sep 8, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/527176 mentions this issue: data/excluded: batch add 14 excluded reports

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/592762 mentions this issue: data/reports: unexclude 75 reports

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/606791 mentions this issue: data/reports: unexclude 20 reports (11)

gopherbot pushed a commit that referenced this issue Aug 21, 2024
  - data/reports/GO-2023-2051.yaml
  - data/reports/GO-2023-2053.yaml
  - data/reports/GO-2023-2055.yaml
  - data/reports/GO-2023-2063.yaml
  - data/reports/GO-2023-2065.yaml
  - data/reports/GO-2023-2066.yaml
  - data/reports/GO-2023-2067.yaml
  - data/reports/GO-2023-2068.yaml
  - data/reports/GO-2023-2069.yaml
  - data/reports/GO-2023-2070.yaml
  - data/reports/GO-2023-2071.yaml
  - data/reports/GO-2023-2072.yaml
  - data/reports/GO-2023-2073.yaml
  - data/reports/GO-2023-2075.yaml
  - data/reports/GO-2023-2078.yaml
  - data/reports/GO-2023-2079.yaml
  - data/reports/GO-2023-2080.yaml
  - data/reports/GO-2023-2084.yaml
  - data/reports/GO-2023-2085.yaml
  - data/reports/GO-2023-2088.yaml

Updates #2051
Updates #2053
Updates #2055
Updates #2063
Updates #2065
Updates #2066
Updates #2067
Updates #2068
Updates #2069
Updates #2070
Updates #2071
Updates #2072
Updates #2073
Updates #2075
Updates #2078
Updates #2079
Updates #2080
Updates #2084
Updates #2085
Updates #2088

Change-Id: I0103dfe39411ae2cf3d74933349260db7dc3496b
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/606791
Commit-Queue: Tatiana Bradley <tatianabradley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
Auto-Submit: Tatiana Bradley <tatianabradley@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module.
Projects
None yet
Development

No branches or pull requests

3 participants