Skip to content

Commit

Permalink
Prepare v1.2.3
Browse files Browse the repository at this point in the history
  • Loading branch information
Sergey Vilgelm committed Jul 14, 2020
1 parent cf72500 commit 5d69c29
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
10 changes: 8 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ The action runs [golangci-lint](https://github.com/golangci/golangci-lint) and r

![GitHub Annotations](./static/annotations.png)

## Compatibility

* `v1.2.3` works with `golangci-lint` version >= `v1.28.3`
* `v1.2.2` is deprecated due to we forgot to change the minimum version of `golangci-lint` to `v1.28.3` ([issue](https://github.com/golangci/golangci-lint-action/issues/39))
* `v1.2.1` works with `golangci-lint` version >= `v1.14.0` ([issue](https://github.com/golangci/golangci-lint-action/issues/39))

## How to use

Add `.github/workflows/golangci-lint.yml` with the following contents:
Expand All @@ -30,8 +36,8 @@ jobs:
uses: golangci/golangci-lint-action@v1
with:
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
version: v1.26
version: v1.28

# Optional: working directory, useful for monorepos
# working-directory: somedir

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "golanci-lint-action",
"version": "1.1.2",
"version": "1.2.3",
"private": true,
"description": "golangci-lint github action",
"main": "dist/main.js",
Expand All @@ -22,7 +22,7 @@
"type": "git",
"url": "git+https://github.com/golangci/golangci-lint-action.git"
},
"author": "GitHub",
"author": "golangci",
"license": "MIT",
"dependencies": {
"@actions/core": "^1.2.0",
Expand Down
6 changes: 3 additions & 3 deletions src/version.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ export const stringifyVersion = (v: Version): string => `v${v.major}.${v.minor}$

const minVersion = {
major: 1,
minor: 14,
patch: 0,
minor: 28,
patch: 3,
}

const isLessVersion = (a: Version, b: Version): boolean => {
Expand Down Expand Up @@ -119,7 +119,7 @@ export async function findLintVersion(): Promise<VersionConfig> {

core.info(
`Requested golangci-lint '${stringifyVersion(reqLintVersion)}', using '${versionConfig.TargetVersion}', calculation took ${Date.now() -
startedAt}ms`
startedAt}ms`
)
return versionConfig
}

0 comments on commit 5d69c29

Please sign in to comment.