Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify usage: don't require github token #11

Closed
jirfag opened this issue May 7, 2020 · 0 comments · Fixed by #13
Closed

Simplify usage: don't require github token #11

jirfag opened this issue May 7, 2020 · 0 comments · Fixed by #13

Comments

@jirfag
Copy link
Member

jirfag commented May 7, 2020

Generate version-maps.json in golangci-lint repository and download it for detecting a last patch version. Using GitHub API without tokens can fail because of 60 req/hour rate limit.

But maybe we will need it again for leaving comments instead of annotations in #5. Need to research.
Even if we need it - we can make it optional only when comments are needed.

jirfag added a commit to golangci/golangci-lint that referenced this issue May 7, 2020
It will be used by GitHub action `golangci-lint-action`.

Relates: golangci/golangci-lint-action#11
jirfag added a commit to golangci/golangci-lint that referenced this issue May 9, 2020
It will be used by GitHub action `golangci-lint-action`.

Relates: golangci/golangci-lint-action#11
jirfag added a commit that referenced this issue May 9, 2020
jirfag added a commit that referenced this issue May 9, 2020
jirfag added a commit that referenced this issue May 9, 2020
jirfag added a commit that referenced this issue May 9, 2020
@jirfag jirfag closed this as completed in #13 May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant