Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nlreturn: support suggested fix #1322

Closed
wreulicke opened this issue Aug 19, 2020 · 4 comments
Closed

nlreturn: support suggested fix #1322

wreulicke opened this issue Aug 19, 2020 · 4 comments
Labels
enhancement New feature or improvement

Comments

@wreulicke
Copy link

Is your feature request related to a problem? Please describe.
New version of nlreturn supports suggested fix.

Describe the solution you'd like
just update to nlreturn v2.1.0

Describe alternatives you've considered
nothing

Additional context

@wreulicke wreulicke added the enhancement New feature or improvement label Aug 19, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 19, 2020

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@sayboras sayboras added the dependencies Relates to an upstream dependency label Aug 21, 2020
@sayboras
Copy link
Member

@wreulicke thanks for your issue, just want to check if you are planning to send PR as well ?

@SVilgelm
Copy link
Member

I tried to do a simple update, the auto-fixing function is not working. The nlreturn uses SuggestedFixes: https://github.com/ssgreg/nlreturn/blob/master/pkg/nlreturn/nlreturn.go#L56-L66 , but the golangci-lint expects Replacement

@ldez ldez changed the title Update to nlreturn v2.1.0. Support suggested fix Support suggested fix Dec 7, 2020
@ldez ldez changed the title Support suggested fix nlreturn: support suggested fix Dec 7, 2020
@ldez ldez removed the dependencies Relates to an upstream dependency label Feb 22, 2021
@ldez
Copy link
Member

ldez commented Feb 25, 2021

Closed in favor of #1779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

4 participants