Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing out SuggestedFixes #1778

Closed
wants to merge 2 commits into from
Closed

Conversation

SVilgelm
Copy link
Member

@SVilgelm SVilgelm commented Feb 25, 2021

output:

pkg/cmd/register/routes.go:40:12: fieldalignment: struct with 32 pointer bytes could be 16 (govet)
type route struct {
           ^
Rearrange fields
struct {
        HTTPMethods map[string]*httpMethod `json:"httpMethods"`
        Route       string                 `json:"route"`
        Streamable  bool                   `json:"isStreamable,omitempty"`
        AdminOnly   bool                   `json:"isAdminOnlyAccess,omitempty"`
        APIOnly     bool                   `json:"apiOnlyAccess,omitempty"`
}

@SVilgelm
Copy link
Member Author

I still don't understand how to use the SuggestedFixes properly, but I want to print them out, at least.

@SVilgelm SVilgelm added feedback required Requires additional feedback help wanted Issue that needs help from a contributor labels Feb 25, 2021
@ldez
Copy link
Member

ldez commented Feb 25, 2021

I'm also working on 😉

I'm able to apply the fixes.

@ldez ldez self-requested a review February 25, 2021 16:47
@ldez
Copy link
Member

ldez commented Feb 25, 2021

Maybe you can open an issue?

related to #1322

@ldez
Copy link
Member

ldez commented Feb 25, 2021

I created an issue: #1779

@SVilgelm
Copy link
Member Author

@ldez
actually I need this for govet, otherwise it's unclear what to do :))
I will keep it open for some time, then will close (when the autofix works)

@SVilgelm
Copy link
Member Author

some screen shots:

Screen Shot 2021-02-25 at 1 59 01 PM

Screen Shot 2021-02-25 at 2 18 59 PM

Screen Shot 2021-02-25 at 2 21 10 PM

nlreturn removes the lines, that's why there are empty lines

@ldez ldez marked this pull request as draft February 26, 2021 01:34
@ldez ldez changed the title WIP: Printing out SuggestedFixes Printing out SuggestedFixes Feb 26, 2021
@CLAassistant

This comment has been minimized.

@ldez ldez added blocked Need's direct action from maintainer and removed feedback required Requires additional feedback help wanted Issue that needs help from a contributor labels Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: auto-fix blocked Need's direct action from maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants