Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of spancheck linter #4310

Closed
alexandear opened this issue Jan 9, 2024 · 2 comments · Fixed by #4316
Closed

Improve description of spancheck linter #4310

alexandear opened this issue Jan 9, 2024 · 2 comments · Fixed by #4316
Labels
area: docs enhancement New feature or improvement

Comments

@alexandear
Copy link
Member

Your feature request related to a problem? Please describe.

The description for the spancheck linter on the website seems excessively lengthy and weirdly formatted (see screenshots). This decreases readability.

image image

Describe the solution you'd like.

Drop examples from the description:

Check for mistakes with OpenTelemetry trace spans.

Common mistakes with OTEL trace spans include forgetting to call End, forgetting to set an Error status, forgetting to record the Error

Describe alternatives you've considered.

N/A

Additional context.

No response

@alexandear alexandear added enhancement New feature or improvement area: docs labels Jan 9, 2024
@ldez ldez changed the title Review and Modify Description of spancheck linter Improve description of spancheck linter Jan 9, 2024
@ldez
Copy link
Member

ldez commented Jan 9, 2024

I think we will just keep "Check for mistakes with OpenTelemetry trace spans."

Cleary the use of go:embed by the linter to handle the doc is a bad idea.

jjti added a commit to jjti/go-spancheck that referenced this issue Jan 12, 2024
@jjti
Copy link
Contributor

jjti commented Jan 12, 2024

whoops! I got that approach from go/tools/analysis packages, eg: https://github.com/golang/tools/blob/6a0605d4e3d20a2ffb313ef9106199551317973d/go/analysis/passes/lostcancel/lostcancel.go#L26

Did not realize we'd display the whole thing in these docs, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs enhancement New feature or improvement
Projects
None yet
3 participants