reduce mem. usage of unused and update staticcheck #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary improvement is in early clearing of
analyzed package's TypeInfo, facts, etc for
whole program analyzers (`unused`). Clear it when it
becomes unused and GC collects them early. Initially this
clearing was performed for all analyzers except `unused`.
Update staticcheck from v0.0.1-2019.2.3 to v0.0.1-2020.1.4
Also in this commit:
* speed up loading packages from export data (2.5s -> 2.1s for std)
by not using mutex for export data since it was allowed in
x/tools#07722704da13
* make an order of execution of linters stable
* update renameio and robustio
* use robustio in caching
Relates: #987, #994, #995, #1011
This was referenced May 3, 2020
thaJeztah
reviewed
May 3, 2020
| minReadSuccesses = attempts / 4 | ||
|
|
||
| case "darwin": | ||
| // The filesystem on macOS 10.14 occasionally fails with "no such file or |
There was a problem hiding this comment.
😞 why can't we have nice things?
I like the "robustio" package though (interesting)
(Also, sorry for the noise; just glancing over the code changes, and learned about this macOS bug)
There was a problem hiding this comment.
Yep.
Also, it's copy-pasted code from Go source
Merged
delete-merged-branch
bot
deleted the
bug/fix-high-memory-usage-on-new-staticcheck
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary improvement is in early clearing of
analyzed package's TypeInfo, facts, etc for
whole program analyzers (
unused). Clear it when itbecomes unused and GC collects them early. Initially this
clearing was performed for all analyzers except
unused.Update staticcheck from v0.0.1-2019.2.3 to v0.0.1-2020.1.4
Also in this commit:
by not using mutex for export data since it was allowed in
x/tools#07722704da13
Relates: #987, #994, #995, #1011