-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use upstream gocyclo. #1739
Use upstream gocyclo. #1739
Conversation
1bee3f6
to
3a9d212
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd pull code from #1741 as it simplifies some code too.
@invidian you can suggest changes in this PR if you want. |
@invidian I applied your suggestions. |
93ea4a6
to
cbfc916
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
cbfc916
to
cec1e78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Gocyclo has been updated https://github.com/fzipp/gocyclo/commits/main
we don't need a fork anymore https://github.com/golangci/gocyclo