Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream gocyclo. #1739

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Use upstream gocyclo. #1739

merged 2 commits into from
Feb 17, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 16, 2021

Gocyclo has been updated https://github.com/fzipp/gocyclo/commits/main

we don't need a fork anymore https://github.com/golangci/gocyclo

@ldez ldez added linter: update version Update version of linter forks We shall not use forks of linters labels Feb 16, 2021
@ldez ldez changed the title feat: use upstream gocyclo. Use upstream gocyclo. Feb 16, 2021
Copy link
Contributor

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd pull code from #1741 as it simplifies some code too.

@ldez
Copy link
Member Author

ldez commented Feb 17, 2021

@invidian you can suggest changes in this PR if you want.

@ldez
Copy link
Member Author

ldez commented Feb 17, 2021

@invidian I applied your suggestions.

Copy link
Contributor

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@ldez ldez mentioned this pull request Feb 17, 2021
Copy link
Member

@ernado ernado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 34e5fc6 into golangci:master Feb 17, 2021
@ldez ldez deleted the fix/remove-gocylco-fork branch February 17, 2021 09:27
ashanbrown pushed a commit to ashanbrown/golangci-lint that referenced this pull request Feb 20, 2021
@ldez ldez added this to the v1.37 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forks We shall not use forks of linters linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants