Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream version of gosec #310

Closed
wants to merge 1 commit into from
Closed

Use upstream version of gosec #310

wants to merge 1 commit into from

Conversation

dhui
Copy link
Contributor

@dhui dhui commented Nov 29, 2018

Addresses: #239

There's a lot of noise in the PR diff since I ran go mod tidy and go mod vendor. The only changes I made were in pkg/golinters/gas.go, the rest of the changes were made by the Go tool chain.

Also, github.com/stretchr/testify was automatically updated from v1.2.1 to v1.2.2 by the Go tool chain, which shouldn't cause any issues...

@dhui
Copy link
Contributor Author

dhui commented Nov 29, 2018

Ahhh, turns out using the upstream version of gosec isn't that simple since the golangci forked version adds the ProcessProgram() method to gosec.Analyzer which works with loaded programs instead of package path strings.

@jirfag
Copy link
Member

jirfag commented Dec 22, 2018

closing, I will do it myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants