lll: skip imports

[ibez92]

Skip long line check on imports.

Fixes #3251

[boring-cyborg]

Hey, thank you for opening your first Pull Request !

[CLAassistant]

All committers have signed the CLA.

[bombsimon]

Thanks for the PR!

I added some suggestions about simplifying the code and also a question about correctness. Maybe worth adding a unit test for this?

Also I'm curious if we should set lineNumber := 0 and do lineNumber++ on line 96. That way you don't need to do that in every new branch you create and just call continue since we should always increment the number on each line we scan.

[ibez92]

Thanks for the PR!

I added some suggestions about simplifying the code and also a question about correctness. Maybe worth adding a unit test for this?

Also I'm curious if we should set lineNumber := 1 and do lineNumber++ on line 96. That way you don't need to do that in every new branch you create and just call continue since we should always increment the number on each line we scan.

Thank you for your reply!

I will try to fix all comments.

One question: could you please guide me where should I put unit test for lll? I don't see any *_test file in the golinters directory. Should I put it there?

[ldez]

@ibez92 you have to sign the CLA

#3288 (comment)

[ibez92]

Yeah, missed my email in commit, sry.

Now it's signed

[bombsimon]

Thanks for the PR!

I added some suggestions about simplifying the code and also a question about correctness. Maybe worth adding a unit test for this?

Also I'm curious if we should set lineNumber := 1 and do lineNumber++ on line 96. That way you don't need to do that in every new branch you create and just call continue since we should always increment the number on each line we scan.

Thank you for your reply!

I will try to fix all comments.

One question: could you please guide me where should I put unit test for lll? I don't see any *_test file in the golinters directory. Should I put it there?

Have a look at testdata. You can probably just set max lengt in the config to something very short and import any internal package.

[ibez92]

Thank you!

I added 2 tests for single and multi import

[bombsimon]

LGTM but can we also add the change to lineNumber to avoid the incrementation at three different places? Basically:

• Set lineNumber := 0 on line 87
• Do lineNumber++ on line 92
• Remove lineNumber++ in all branches (line 97, 106 and 121)

That way we can add any logic and rely on line numbers getting incremented even if we do a continue in a branch.

[ibez92]

Nice point, thank you!

Did as you suggested

[bombsimon]

LGTM, not merging until you've updated your review status @ldez to avoid miscommunication.

[ldez]

LGTM