-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: use to GitHub Pages #3884
dev: use to GitHub Pages #3884
Conversation
on: | ||
push: | ||
branches: | ||
- master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this will be an alternative official documentation, should this rather be when tagging and not pushing to master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently, we publish the doc every time a change happens on the doc.
It's a requirement to be able to apply a fix on the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! Would be nice if we could clarify that. It will f.ex. also add docs for new linters not yet released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already the case, I added Since
in the documentation there is a long time ago (2021) in #1854.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I know but that requires people to actually read the docs and figure out what the current version is :)
It was also just an example but let’s see if it becomes a problem and not try to solve anything until then!
Currently, only one person has access to the Netlify administration (it's not me) and this is a problem because it can be really difficult when we have to update something inside the Netlify admin.
It will be easier to diagnose and fix problems like #3663.
This PR introduces Github Pages in parallel with Netlify because we need to have the branch and the content before setting up the custom domain.
When we will set the custom domain, I will open another PR to remove Netlify-related files.
FYI: I tested this PR on my fork.