output: convert backslashes to forward slashes for GitHub Action annotations printer #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue in the GitHub Actions printer where file paths were using backslashes on Windows systems. As result we didn't see correct annotations in the PRs. To ensure proper formatting we always convert to forward slash separator in filepathes.
|
Hey, thank you for opening your first Pull Request ! |
|
|
|
Example of the issue I am trying to solve here: There is an error annotation which is not shown in the PR changes when running on Windows. With the forward slashes on Linux it works fine. I'm assuming the GitHub always wants it with forward slashes. |
surik
changed the title
ldez
added
enhancement
ldez
changed the title
ldez
added
bug
ldez
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue in the GitHub Actions printer where file paths were using backslashes on Windows systems.
As result we didn't see correct annotations in the PRs. To ensure proper formatting we always convert to forward slash separator in filepathes.